Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 7 Aug 2021 16:05:06 +0200
From:   =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Kevin Liu <kliu5@marvell.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Suneel Garapati <suneel.garapati@xilinx.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Al Cooper <alcooperx@gmail.com>
Subject: Re: [PATCH v4 2/5] mmc: sdhci: always obey programmable clock config
 in preset value
Message-ID: <YQ6TEhMLXH/4r4BS@qmqm.qmqm.pl>
References: <cover.1627204633.git.mirq-linux@rere.qmqm.pl>
 <e65dc96eb24caf8baa5431a51fe694b969e2d51f.1627204633.git.mirq-linux@rere.qmqm.pl>
 <fe01b20d-779b-1e2c-7702-5a4702900d84@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fe01b20d-779b-1e2c-7702-5a4702900d84@intel.com>
Precedence: bulk

On Wed, Aug 04, 2021 at 01:52:21PM +0300, Adrian Hunter wrote:
> On 25/07/21 12:20 pm, Micha? Miros?aw wrote:
> > When host controller uses programmable clock presets but doesn't
> > advertise programmable clock support, we can only guess what frequency
> > it generates. Let's at least return correct SDHCI_PROG_CLOCK_MODE bit
> > value in this case.
> If the preset value doesn't make sense, why use it at all?

If I understand the spec correctly, when the preset value is used the
values in Clock Control register are ignored by the module and so the
module can also actually use a different clock source than the ones
available to the driver directly. So either way the driver can't be
sure of the exact frequencu used. This is a cleanup to remove a case
when the code ignores a bit's value based on other unspecified assumptions.

[...]
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -1859,11 +1859,14 @@ u16 sdhci_calc_clk(struct sdhci_host *host, unsigned int clock,
> >  
> >  			pre_val = sdhci_get_preset_value(host);
> >  			div = FIELD_GET(SDHCI_PRESET_SDCLK_FREQ_MASK, pre_val);
> > -			if (host->clk_mul &&
> > -				(pre_val & SDHCI_PRESET_CLKGEN_SEL)) {
> > +			if (pre_val & SDHCI_PRESET_CLKGEN_SEL) {
> >  				clk = SDHCI_PROG_CLOCK_MODE;
> >  				real_div = div + 1;
> >  				clk_mul = host->clk_mul;
> > +				if (!clk_mul) {
> > +					/* The clock frequency is unknown. Assume undivided base. */
> > +					clk_mul = 1;
> > +				}
> >  			} else {
> >  				real_div = max_t(int, 1, div << 1);
> >  			}