Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge
 timings support
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <CAG3jFyu50h2oLW0U6hJSpxiKp3Hb5Ow8Ujvg2qdKRuy+uhaahw@mail.gmail.com>
Date:   Sun, 8 Aug 2021 06:50:13 +0200
Cc:     Paul Cercueil <paul@crapouillou.net>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Kees Cook <keescook@chromium.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Ezequiel Garcia <ezequiel@collabora.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maxime Ripard <maxime@cerno.tech>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, linux-mips@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        letux-kernel@openphoenux.org, Paul Boddie <paul@boddie.org.uk>,
        Jonas Karlman <jonas@kwiboo.se>,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <79C56341-BB3E-4AFC-A595-6EE2ED603FC2@goldelico.com>
References: <cover.1628172477.git.hns@goldelico.com>
 <15187eccabf39561de226acd8be40b93503cac49.1628172477.git.hns@goldelico.com>
 <CAG3jFyu50h2oLW0U6hJSpxiKp3Hb5Ow8Ujvg2qdKRuy+uhaahw@mail.gmail.com>
To:     Robert Foss <robert.foss@linaro.org>
Precedence: bulk

Hi Robert,


> Am 05.08.2021 um 16:32 schrieb Robert Foss <robert.foss@linaro.org>:
>=20
> Hey Nikolaus,
>=20
> Thanks for submitting this series.
>=20
> On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller <hns@goldelico.com> =
wrote:
>>=20
>> From: Paul Boddie <paul@boddie.org.uk>
>>=20
>> static void dw_hdmi_bridge_mode_set(struct drm_bridge *bridge,
>>                                    const struct drm_display_mode =
*orig_mode,
>>                                    const struct drm_display_mode =
*mode)
>> @@ -2883,6 +2896,7 @@ static const struct drm_bridge_funcs =
dw_hdmi_bridge_funcs =3D {
>>        .atomic_disable =3D dw_hdmi_bridge_atomic_disable,
>>        .mode_set =3D dw_hdmi_bridge_mode_set,
>>        .mode_valid =3D dw_hdmi_bridge_mode_valid,
>> +       .mode_fixup =3D dw_hdmi_bridge_mode_fixup,
>=20
> mode_fixup() has been deprecated[1] in favor of atomic_check(), care
> has to be taken when switching to atomic_check() as it has access to
> the full atomic commit.
>=20
> Looking at this driver, it's using mode_set as well, which should be =
fixed.
>=20
> [1] =
https://lore.kernel.org/dri-devel/20210722062246.2512666-8-sam@ravnborg.or=
g/

We have moved code from mode_fixup() to atomic_check().
Was not difficult.

v3 will come soon.

BR and thanks,
Nikolaus Schaller