Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: SjiJLIpTnTJwNxyaB4twf/JhkPMUq6C7qruGg3GJgP0z+gx04xi96wi2kGT3AVvMllWiemZTJs
 eKBhJitmVxNgoOZm2ZfR6DgADAi5GDmeB8qEJih+nWOgRwAV/obMjDl95IjUBbMO+YpEsWK9Bk
 Wn5LqRId18wqBAKDfeSk9ERJYPYN1N/qGjLzsA8FGjLLHh+PXMnyX1bwstkYMKEEBJ5Y8WznWn
 qP6gjdo16+1UPglmiAcB60Z6/m7YAJgbvh0jz18I2R6C5eXKZi7jKxOzzrlmZw3WSIh+mud3lP
 +YEpbybqXMT3B+6hItpTTuog
IronPort-SDR: 07lasYtr7CfWz+iI2OWhYHfFO0K7Qt7DVXzowy6cK9b/esIEbwoqSwJhIT+1Z/d5bYo6pvwgKf
 AK7mSAtJptbxr92CITg8VT1+saIy6eRHKsOwELek7l++Tdvb+ar/C1UFESueg0+8jGUH3O4Z83
 QzQU4fL1tO12sndpr+C7YYft3blQhp1ucVpOhKEG6+fNaEVdN4HuJrAv/UyWKTJPPon8GG4iRH
 5sauHDsxLAb+xH+D+ydZ/JnX5KEXDhNEquEFHufe1EHMxQpVhOvQwyTbsATosJMnHGgR7d/4XM
 3eQ=
WDCIronportException: Internal
From:   Avri Altman <avri.altman@wdc.com>
To:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bart Van Assche <bvanassche@acm.org>,
        Daejun Park <daejun7.park@samsung.com>,
        Avri Altman <avri.altman@wdc.com>
Subject: [PATCH 2/4] scsi: ufshpb: Use a correct max multi chunk
Date:   Sun,  8 Aug 2021 12:00:22 +0300
Message-Id: <20210808090024.21721-3-avri.altman@wdc.com>
In-Reply-To: <20210808090024.21721-1-avri.altman@wdc.com>
References: <20210808090024.21721-1-avri.altman@wdc.com>
Precedence: bulk

In HPB2.0, if pre_req_min_tr_len < transfer_len < pre_req_max_tr_len
the driver is expected to send a HPB-WRITE-BUFFER companion to HPB-READ.

The upper bound should fit into a single byte, regardless of
bMAX_ DATA_SIZE_FOR_HPB_SINGLE_CMD which being an attribute (u32) can
be significantly larger.

To further illustrate the issue let us consider the following scenario:
 - SCSI_DEFAULT_MAX_SECTORS is 1024 limiting the IO chunks to 512KB
 - The OEM changes scsi_host_template .max_sectors to be 2048, which
   allows a 1M requests: transfer_len = 256
 - pre_req_max_tr_len = HPB_MULTI_CHUNK_HIGH = 256
 - ufshpb_is_supported_chunk returns true (256 <= 256)
 - WARN_ON_ONCE(256 > 256) doesn't warn
 - ufshpb_set_hpb_read_to_upiu cast transfer_len to u8: transfer_len = 0
 - the command is failing with illegal request

Fixes: 41d8a9333cc9 (scsi: ufs: ufshpb: Add HPB 2.0 support)
Signed-off-by: Avri Altman <avri.altman@wdc.com>
---
 drivers/scsi/ufs/ufshpb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
index c74a6c35a446..6df317dfe034 100644
--- a/drivers/scsi/ufs/ufshpb.h
+++ b/drivers/scsi/ufs/ufshpb.h
@@ -32,7 +32,7 @@
 /* hpb support chunk size */
 #define HPB_LEGACY_CHUNK_HIGH			1
 #define HPB_MULTI_CHUNK_LOW			7
-#define HPB_MULTI_CHUNK_HIGH			256
+#define HPB_MULTI_CHUNK_HIGH			255
 
 /* hpb vender defined opcode */
 #define UFSHPB_READ				0xF8
-- 
2.17.1