Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp2008636pxt;
        Sun, 8 Aug 2021 08:32:43 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwGy2mEZz8Tj0j+hneSIRU5yMCXyyTU8mMYP6idLpzRA/nzZRj3Ygedg2IJyC3zNt1go1B+
X-Received: by 2002:a05:6402:4245:: with SMTP id g5mr13640027edb.222.1628436763196;
        Sun, 08 Aug 2021 08:32:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1628436763; cv=none;
        d=google.com; s=arc-20160816;
        b=TahPiVEtl2QwLxmmP37JjFx8zVCNSbx934Tb+GVhniY5rFZyLNCRtPDsdmzNk49Qyn
         1S7DQ8DfRpvTazoGwWc8PoH6vitT3SOmKfTipfZjPj+VnZFbKjqVOe2FzjbosGr9nNiD
         hlKUGobUHNJImFfoHdUjlesjwh4AW5y1SWCp8eUjnY28Ed6esIjOYtJWo8o/McsNaRUl
         /RK/efojbyiIFZND3FL/sVHdqz/NMpb+tsKiBaTYoHM/wnU5D1LWHGJ5Us1SfctsWPzG
         9AuNSvu6lIv9oCiK0fpMn0LYbIsdSe1ThfQeHq3PY4EdQkY0Eo5QaKy8AXZeBH0sr1ow
         a+6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=kFPCh7JAhBnmZtTF9Kdic0vRFx4iPcluqAVKggzCljo=;
        b=OqQkku0gSHlCvvaFnwieq5M0w/LnEJ9XTMYOr9cvoPJVo0Rrfu6+KkxYI6BJvosgmF
         IgcHvvis/Y8zXRzngLCTa3RgNZaPlF/ldRB38frpAcOOf0vsllXCpppu2cq4O7DVQKch
         EJQ9MV42MvBoKoh1Vikc0SU2LuuEsV0UODRrVjtuE/l2YvTvZY+ilBfvS22F6sUbVSS6
         6rK9jAN3FKsHa/+8ryVzldRaZN5EoPQDfoOR8OuvQpRdvsmRrRdoTju8AVc/FUbkZTGu
         OKgfNQGXUSPD0Qs61lexRunlvB8QG57KLA8S/9nFlwCvutee+/mRIxtX7YPwNyme17dS
         nU1w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=MbkN08r5;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p15si1299542edq.262.2021.08.08.08.32.19;
        Sun, 08 Aug 2021 08:32:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=MbkN08r5;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232049AbhHHPaI (ORCPT <rfc822;liqb365@gmail.com> + 99 others);
        Sun, 8 Aug 2021 11:30:08 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:38828 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229923AbhHHPaH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 8 Aug 2021 11:30:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=kFPCh7JAhBnmZtTF9Kdic0vRFx4iPcluqAVKggzCljo=; b=MbkN08r5JVHVsWZ/mmW/xRt9aV
        wTQIFqvenSzSes0e4EpBWnYzU2eoWfCe00AuPvl2N8AFhoocJpU6CekO0NQ3WzqRdXiAVV6C7oYjm
        TSpKp1va3cvunoTyln4bjVzO3TP4MmECZNS5YweuZFMKZFfu+r9eZGIXhkcXc1KN9xv0=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1mCkkC-00Gamm-UA; Sun, 08 Aug 2021 17:29:44 +0200
Date:   Sun, 8 Aug 2021 17:29:44 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Luo Jie <luoj@codeaurora.org>
Cc:     hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org,
        linux@armlinux.org.uk, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH v1 1/2] net: mdio: Add the reset function for IPQ MDIO
 driver
Message-ID: <YQ/4aK3yYPvYQdhD@lunn.ch>
References: <20210808072111.8365-1-luoj@codeaurora.org>
 <20210808072111.8365-2-luoj@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210808072111.8365-2-luoj@codeaurora.org>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +	/* Configure MDIO clock source frequency if clock is specified in the device tree */
> +	if (!IS_ERR_OR_NULL(priv->mdio_clk)) {

Please document the clock in the binding. Make it clear which devices
require the clock, and which don't.

	Andrew