Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 8 Aug 2021 17:47:55 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Luo Jie <luoj@codeaurora.org>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org, davem@davemloft.net,
        kuba@kernel.org, robh+dt@kernel.org, robert.marko@sartura.hr,
        linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        sricharan@codeaurora.org
Subject: Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO
Message-ID: <YQ/8q6gR6Eji2hKD@lunn.ch>
References: <20210808075328.30961-1-luoj@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210808075328.30961-1-luoj@codeaurora.org>
Precedence: bulk

On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote:
> The new added properties resource "reg" is for configuring
> ethernet LDO in the IPQ5018 chipset, the property "clocks"
> is for configuring the MDIO clock source frequency.
> 
> This patch depends on the following patch:
> Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO
> driver")

Please always make binding patches part of the series containing the
driver code. We sometimes need to see both to do a proper review.

Add a comment about when the second address range and clock is
required. Does qcom,ipq5018-mdio require them?

	  Andrew