Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210807145619.832-1-caihuoqing@baidu.com> <05a5ddb5-1c51-8679-60a3-a74e0688b72d@gmail.com>
In-Reply-To: <05a5ddb5-1c51-8679-60a3-a74e0688b72d@gmail.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Sun, 8 Aug 2021 21:49:41 +0200
Message-ID: <CAK8P3a0FUGbwbWuu0R7-Bm4O0MgNfYmE4FTZY9oE9jnRcMK9xQ@mail.gmail.com>
Subject: Re: [PATCH 0/2] net: ethernet: Remove the 8390 network drivers
To:     Michael Schmitz <schmitzmic@gmail.com>
Cc:     Cai Huoqing <caihuoqing@baidu.com>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Aug 8, 2021 at 12:51 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>
> Removing the 8390 drivers would leave most m68k legacy systems without
> networking support.
>
> Unless there is a clear and compelling reason to do so, these drivers
> should not be removed.

Right, any driver that is tied to a particular machine should generally
be left working as long as we support that machine.

> >  MAINTAINERS                           |    6 -
> >  drivers/net/ethernet/8390/8390.c      |  103 --
> >  drivers/net/ethernet/8390/8390.h      |  236 ----
> >  drivers/net/ethernet/8390/8390p.c     |  105 --
> >  drivers/net/ethernet/8390/Kconfig     |  212 ---
> >  drivers/net/ethernet/8390/Makefile    |   20 -
> >  drivers/net/ethernet/8390/apne.c      |  619 ---------
> >  drivers/net/ethernet/8390/ax88796.c   | 1022 ---------------
> >  drivers/net/ethernet/8390/axnet_cs.c  | 1707 ------------------------
> >  drivers/net/ethernet/8390/etherh.c    |  856 -------------
> >  drivers/net/ethernet/8390/hydra.c     |  273 ----
> >  drivers/net/ethernet/8390/lib8390.c   | 1092 ----------------
> >  drivers/net/ethernet/8390/mac8390.c   |  848 ------------
> >  drivers/net/ethernet/8390/mcf8390.c   |  475 -------
> >  drivers/net/ethernet/8390/ne.c        | 1004 ---------------
> >  drivers/net/ethernet/8390/ne2k-pci.c  |  747 -----------
> >  drivers/net/ethernet/8390/pcnet_cs.c  | 1708 -------------------------
> >  drivers/net/ethernet/8390/smc-ultra.c |  629 ---------
> >  drivers/net/ethernet/8390/stnic.c     |  303 -----
> >  drivers/net/ethernet/8390/wd.c        |  574 ---------
> >  drivers/net/ethernet/8390/xsurf100.c  |  377 ------
> >  drivers/net/ethernet/8390/zorro8390.c |  452 -------

Two candidates I can see for removing would be smc-ultra and
wd80x3, both of them fairly rare ISA cards. The only other
ISA 8390 variant is the ne2000 driver (ne.c), which is probably
the most common ISA card overall, and I'd suggest leaving
that in place for as long as we support CONFIG_ISA.

There are a couple of other ISA-only network drivers (localtalk,
arcnet,  ethernet/amd) that may be candidates for removal,
or perhaps some PCMCIA ones.

      Arnd