Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/2] net: ethernet: Remove the 8390 network drivers
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Cai Huoqing <caihuoqing@baidu.com>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20210807145619.832-1-caihuoqing@baidu.com>
 <05a5ddb5-1c51-8679-60a3-a74e0688b72d@gmail.com>
 <CAK8P3a0FUGbwbWuu0R7-Bm4O0MgNfYmE4FTZY9oE9jnRcMK9xQ@mail.gmail.com>
From:   Michael Schmitz <schmitzmic@gmail.com>
Message-ID: <bd0a1112-af59-16be-3fd3-b0a6aa1f2773@gmail.com>
Date:   Mon, 9 Aug 2021 08:38:02 +1200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAK8P3a0FUGbwbWuu0R7-Bm4O0MgNfYmE4FTZY9oE9jnRcMK9xQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hi Arnd,

On 9/08/21 7:49 am, Arnd Bergmann wrote:
> On Sun, Aug 8, 2021 at 12:51 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> Removing the 8390 drivers would leave most m68k legacy systems without
>> networking support.
>>
>> Unless there is a clear and compelling reason to do so, these drivers
>> should not be removed.
> Right, any driver that is tied to a particular machine should generally
> be left working as long as we support that machine.
Thanks - if it was any help to alleviate the maintenance burden, I'd be 
happy to help look after that section of the network drivers.
>
>>>   MAINTAINERS                           |    6 -
>>>   drivers/net/ethernet/8390/8390.c      |  103 --
>>>   drivers/net/ethernet/8390/8390.h      |  236 ----
>>>   drivers/net/ethernet/8390/8390p.c     |  105 --
>>>   drivers/net/ethernet/8390/Kconfig     |  212 ---
>>>   drivers/net/ethernet/8390/Makefile    |   20 -
>>>   drivers/net/ethernet/8390/apne.c      |  619 ---------
>>>   drivers/net/ethernet/8390/ax88796.c   | 1022 ---------------
>>>   drivers/net/ethernet/8390/axnet_cs.c  | 1707 ------------------------
>>>   drivers/net/ethernet/8390/etherh.c    |  856 -------------
>>>   drivers/net/ethernet/8390/hydra.c     |  273 ----
>>>   drivers/net/ethernet/8390/lib8390.c   | 1092 ----------------
>>>   drivers/net/ethernet/8390/mac8390.c   |  848 ------------
>>>   drivers/net/ethernet/8390/mcf8390.c   |  475 -------
>>>   drivers/net/ethernet/8390/ne.c        | 1004 ---------------
>>>   drivers/net/ethernet/8390/ne2k-pci.c  |  747 -----------
>>>   drivers/net/ethernet/8390/pcnet_cs.c  | 1708 -------------------------
>>>   drivers/net/ethernet/8390/smc-ultra.c |  629 ---------
>>>   drivers/net/ethernet/8390/stnic.c     |  303 -----
>>>   drivers/net/ethernet/8390/wd.c        |  574 ---------
>>>   drivers/net/ethernet/8390/xsurf100.c  |  377 ------
>>>   drivers/net/ethernet/8390/zorro8390.c |  452 -------
> Two candidates I can see for removing would be smc-ultra and
> wd80x3, both of them fairly rare ISA cards. The only other
> ISA 8390 variant is the ne2000 driver (ne.c), which is probably
> the most common ISA card overall, and I'd suggest leaving
> that in place for as long as we support CONFIG_ISA.
That particular driver is the one I rely on (via a weird ROM-port to ISA 
bridge). Would be useful even after ISA bus support is gone, in that 
case. Just saying. The Amiga and Mac drivers likewise. Though you may 
well argue that once ISA support has been removed, these can all be 
rewritten to support MMIO more directly (and more flexibly).
> There are a couple of other ISA-only network drivers (localtalk,
> arcnet,  ethernet/amd) that may be candidates for removal,
> or perhaps some PCMCIA ones.

ethernet/amd has the other set of network card drivers used on m68k 
(*lance).

Cheers,

     Michael


>
>        Arnd