Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH 0/5] Cleanups and fixup for gup
To:     Miaohe Lin <linmiaohe@huawei.com>, <akpm@linux-foundation.org>
CC:     <imbrenda@linux.ibm.com>, <kirill.shutemov@linux.intel.com>,
        <jack@suse.cz>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20210807093620.21347-1-linmiaohe@huawei.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <9ddcde41-7222-8afe-1884-5544d6b5fae6@nvidia.com>
Date:   Sun, 8 Aug 2021 14:13:36 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210807093620.21347-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2021 21:13:37.9864
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d5af6b6-60dd-43e1-5bde-08d95ab163e7
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT032.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2618
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/7/21 2:36 AM, Miaohe Lin wrote:
> Hi all,
> This series contains cleanups to remove unneeded variable, useless
> BUG_ON and use helper to improve readability. Also we fix a potential
> pgmap refcnt leak. More details can be found in the respective
> changelogs. Thanks!
> 
> Miaohe Lin (5):
>    mm: gup: remove set but unused local variable major
>    mm: gup: remove unneed local variable orig_refs
>    mm: gup: remove useless BUG_ON in __get_user_pages()
>    mm: gup: fix potential pgmap refcnt leak in __gup_device_huge()
>    mm: gup: use helper PAGE_ALIGNED in populate_vma_page_range()
> 
>   mm/gup.c | 16 ++++++----------
>   1 file changed, 6 insertions(+), 10 deletions(-)
> 

For the series:

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA