Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Sun, 08 Aug 2021 18:46:54 -0400
Message-Id: <CDEHW1G78JUJ.CQG08OEMNYLQ@shaak>
Cc:     <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH v5 1/5] iio: adc: ad7949: define and use bitfield names
From:   "Liam Beguin" <liambeguin@gmail.com>
To:     "Joe Perches" <joe@perches.com>, <lars@metafoo.de>,
        <Michael.Hennerich@analog.com>, <jic23@kernel.org>,
        <charles-antoine.couret@essensium.com>, <Nuno.Sa@analog.com>
References: <20210808015659.2955443-1-liambeguin@gmail.com>
 <20210808015659.2955443-2-liambeguin@gmail.com>
 <b52eb842e1c681b88dbffba262075957b9741262.camel@perches.com>
In-Reply-To: <b52eb842e1c681b88dbffba262075957b9741262.camel@perches.com>
Precedence: bulk

On Sun Aug 8, 2021 at 12:51 PM EDT, Joe Perches wrote:
> On Sat, 2021-08-07 at 21:56 -0400, Liam Beguin wrote:
> > Replace raw configuration register values by using FIELD_PREP and
> > defines to improve readability.
> []
> > diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c
> []
> +#define AD7949_CFG_BIT_INCC GENMASK(12, 10)
>

Hi Joe,

> I think the naming is a bit confusing as it appears as if
> these bitfield ranges are single bits.

That makes sense.
Would AD7949_CFG_BITS_* be good enough?

Thanks,
Liam

>
> > +/* REF: reference/buffer selection */
> > +#define AD7949_CFG_BIT_REF		GENMASK(5, 3)
> []
> > +/* SEQ: channel sequencer. Allows for scanning channels */
> > +#define AD7949_CFG_BIT_SEQ		GENMASK(2, 1)
> >=20