Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 8 Aug 2021 21:29:29 -0700 (PDT)
From:   Hugh Dickins <hughd@google.com>
To:     Matthew Wilcox <willy@infradead.org>
cc:     Hugh Dickins <hughd@google.com>, Zi Yan <ziy@nvidia.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        David Hildenbrand <david@redhat.com>, linux-mm@kvack.org,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Michal Hocko <mhocko@kernel.org>,
        John Hubbard <jhubbard@nvidia.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 00/15] Make MAX_ORDER adjustable as a kernel boot
 time parameter.
In-Reply-To: <YQ3dn1oR2d0sO5jl@casper.infradead.org>
Message-ID: <c2a4dd1d-c1ac-876b-4a3-c5ea7555498@google.com>
References: <20210805190253.2795604-1-zi.yan@sent.com> <0d374eed-cc52-a656-b338-1156782bdf7e@suse.cz> <F34DBD0A-22DE-4CF2-B784-BBDD80A8E85A@nvidia.com> <6ae6cd92-3ff4-7ed3-b337-a4dfe33da1c@google.com> <YQ3dn1oR2d0sO5jl@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 7 Aug 2021, Matthew Wilcox wrote:
> 
> I am, however, of the opinion that 2MB pages give us so much trouble
> because they're so very special.  Few people exercise those code paths and
> it's easy to break them without noticing.  This is partly why I want to
> do arbitrary-order pages.  If everybody is running with compound pages
> all the time, we'll see the corner cases often, and people other than
> Hugh, Kirill and Mike will be able to work on them.

I don't entirely agree.  I'm all for your use of compound pages in page
cache, but don't think its problems are representative of the problems
in aiming for a PMD (or PUD) bar, with the weird page table transitions
we expect of "THP" there.

I haven't checked: is your use of compound pages in page cache still
limited to the HAVE_ARCH_TRANSPARENT_HUGEPAGE architectures?  When
the others could just as well use compound pages in page cache too.

Hugh