Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp2386286pxt; Sun, 8 Aug 2021 22:10:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkb6K0PJyAPgFObrT30B280nNobmJof9OV5pPVuaax/ve9q1ZXC52JhOQS6VRcxoVG7hmu X-Received: by 2002:a17:906:3693:: with SMTP id a19mr21527555ejc.237.1628485828228; Sun, 08 Aug 2021 22:10:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628485828; cv=none; d=google.com; s=arc-20160816; b=z1wPkQNMbLJpLIkQBi8vsTX5cF4TDfJOXJyfX+iCtZ4Z3/qgZaCoCO6YMz0LWvYXm3 7nz0bSMXhU/Queauz6VrZySI6sVP3VkhK4MX/XLobiDLE5Ku9y2bLdt5/R4H4EChvgfO aIYLgPLJjQEAOtvGX26ChwizwMx8eRkJIJmk9qMx07X7RRi4RY1yixhx7YF1I/sjyAnk wiCtsTROS7hAEY0Tp6VQTptxW+l+Y/k3Jsfcyd42nKsFL0pPckdjKmWgCSZH4gNIDbij uZwYQtFsNYkwBcEJ8MXaN3MHnBlTLppHjTiWqPt+tpEVkljN7SxXEaD12HJBqnwkn/PT i5yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=JZRleE6npgPvgpKitvxmo8658bS2/7i+ZEXGdNQfWak=; b=0aB48DVEGFQFloAiHinBPk4Hm7/fut61tR8h5MQNRBZAUvIS5MRCAVZCUmjgKvGCNk lPxnryV142TCose2Dyoeam6oOgoFlD6bdMqMjdujYgtH2UvfusskclWpkip80fjSxRtM wD85BBf29ZA3SuBJYhn/Pq1vuguYtc7m+2yyshZk9E9iFOv7CFFLikkQfVA1Z7mhOw3A 68c9yoQQ6/6JWyutMFifT8Co9ZfN8yIWS2z5uLjEQ9QRHBxtf7gcaTPCEVJaAmBsSkbR ql1JM5aYQUox1ccOVmvO937w3Vys0Nip3vzvuhgKQBRZXvKHsH7oS8LSyIYXVE8zn07P mUfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g22si15868765edb.11.2021.08.08.22.10.03; Sun, 08 Aug 2021 22:10:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232875AbhHIFBX (ORCPT + 99 others); Mon, 9 Aug 2021 01:01:23 -0400 Received: from foss.arm.com ([217.140.110.172]:52802 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232786AbhHIFBW (ORCPT ); Mon, 9 Aug 2021 01:01:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D1311042; Sun, 8 Aug 2021 22:01:02 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2737F3F718; Sun, 8 Aug 2021 22:01:01 -0700 (PDT) From: Sudeep Holla To: Rishabh Bhatnagar , cristian.marussi@arm.com Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, adharmap@codeaurora.org, avajid@codeaurora.org Subject: Re: [PATCH v3] firmware: arm_scmi: Free mailbox channels if probe fails Date: Mon, 9 Aug 2021 06:00:57 +0100 Message-Id: <162848516052.232525.343233021782950735.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1628111999-21595-1-git-send-email-rishabhb@codeaurora.org> References: <1628111999-21595-1-git-send-email-rishabhb@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Aug 2021 14:19:59 -0700, Rishabh Bhatnagar wrote: > Mailbox channels for the base protocol are setup during probe. > There can be a scenario where probe fails to acquire the base > protocol due to a timeout leading to cleaning up of all device > managed memory including the scmi_mailbox structure setup during > mailbox_chan_setup function. > [ 12.735104]arm-scmi soc:qcom,scmi: timed out in resp(caller: version_get+0x84/0x140) > [ 12.735224]arm-scmi soc:qcom,scmi: unable to communicate with SCMI > [ 12.735947]arm-scmi: probe of soc:qcom,scmi failed with error -110 > > [...] Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/1] firmware: arm_scmi: Free mailbox channels if probe fails https://git.kernel.org/sudeep.holla/c/1e7cbfaa66 -- Regards, Sudeep