Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <8419a1b779a65ab3df8c90e7abc46759360066aa.camel@ew.tq-group.com>
Subject: Re: [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ
 is set
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Mon, 09 Aug 2021 09:11:44 +0200
In-Reply-To: <CAHp75VeQxr3pkX9j10wUi3NjZY-Nkn=waPsMDxG=pDprY3Wsyg@mail.gmail.com>
References: <cover.1626429286.git.matthias.schiffer@ew.tq-group.com>
         <65f9787ebd6725e90fad9ea7f936ee0d5712da94.1626429286.git.matthias.schiffer@ew.tq-group.com>
         <YQvn9dkFluRYj80r@google.com>
         <9dc9fb4b37f7afa661bf1bb9148e5109b3f4329c.camel@ew.tq-group.com>
         <CAHp75VeQxr3pkX9j10wUi3NjZY-Nkn=waPsMDxG=pDprY3Wsyg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-08-05 at 16:42 +0300, Andy Shevchenko wrote:
> On Thu, Aug 5, 2021 at 4:40 PM Matthias Schiffer
> <matthias.schiffer@ew.tq-group.com> wrote:
> > On Thu, 2021-08-05 at 14:30 +0100, Lee Jones wrote:
> > > On Fri, 16 Jul 2021, Matthias Schiffer wrote:
> 
> ...
> 
> > > Strange - why is this !0 in the first place?
> > 
> > I don't see anything strange here. DEFINE_RES_IRQ() sets flags to
> > IORESOURCE_IRQ. We reset it to 0 when there is no IRQ to clear that
> > resource entry.
> > 
> > An alternative would be to start with an empty entry and only fill in
> > the fields when an IRQ is used, but that seems more cumbersome than the
> > current code to me.
> 
> Another alternative is to start using the IRQ DISABLED resource flag,
> but I'm afraid that OF code is not ready for that.
> https://elixir.bootlin.com/linux/latest/source/include/linux/ioport.h#L331
> 

As this patch is a fairly simple bugfix, I'd prefer to get it (or a
similar fix) applied without having to wait for improvements of the
core code - also for the sake of stable backports.