Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Nishad Kamdar <nishadkamdar@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Jens Axboe <axboe@kernel.dk>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bean Huo <beanhuo@micron.com>,
        Shawn Lin <shawn.lin@rock-chips.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] mmc: core: Return correct emmc response in case of
 ioctl error
Thread-Topic: [PATCH v2] mmc: core: Return correct emmc response in case of
 ioctl error
Thread-Index: AQHXjHpellXktnu2k0aKNPm/Pz8mzatq2HAA
Date:   Mon, 9 Aug 2021 08:41:19 +0000
Message-ID: <DM6PR04MB6575FA52433A1A3C7F89453BFCF69@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210808172448.4641-1-nishadkamdar@gmail.com>
In-Reply-To: <20210808172448.4641-1-nishadkamdar@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5Ple2/eT+RcicRWLibyuQHcHIZfYj7WmDU54w/zC5YIKuh/cAUwt0w/toxgT?=
 =?us-ascii?Q?oC56KrFI9xXBm0cFHZV5YVuhyd3Y5gZ9D9rx4z0m8Gq445s9716gt+E/0LXA?=
 =?us-ascii?Q?EwlHBAZSrRwmwZp7hHdiVNxLx9sHC9tSuKIKM9h/6z1o3aQNLYhgRgRTaGmK?=
 =?us-ascii?Q?ZWML1GUzvdqpa6wAEi4If0XihfLM1PmzzoaO4oDg1rn3zg3gNUL8A2lKJgma?=
 =?us-ascii?Q?NfTNyzQDtsZVNzO8uKCKjxB6tYFWdn9Kei/bbOVKbLDdN5zbiqP4hsLPO1Fl?=
 =?us-ascii?Q?lUo59JOJTEeiiKRZpICEbTdLHgtvlOP2udX+a7yZXQFCW/5y6MplGuzmqoXt?=
 =?us-ascii?Q?UyM+hkSNf5AX1vziN4ZhUfvAKaJrwpgn2kvtzjri6SAE83fcJx6vezMO3YnQ?=
 =?us-ascii?Q?PYKmlF+XstfDK6lb6mNKbidLfyF4q5rPG14cEaDJx5TRXAxTKzaD0ZAI0Jz/?=
 =?us-ascii?Q?mNfdyvtBwNNkAjWCNjIndRQl7oEWhFFMwnbNSnyz0ZdEu69A4FFxvmRpCvgu?=
 =?us-ascii?Q?GU2TJZsvBLRf2Fp7slIG/VZ5Fd9OYcrhy6fwzh8ES/nh6q0BXI61lIAz8xal?=
 =?us-ascii?Q?il4NxtXdpTo1TAUulE33p1MSuySWqqqtQ8goA3jhPR4i1IxZekPmtkrKRYbs?=
 =?us-ascii?Q?s5fBfjVyM9qxbVttL+6LQBwkUldnL+oLb6X5X9xibhPHWKgndC8OnquX+iTm?=
 =?us-ascii?Q?M6uxnbMHfmYkRVKRffJ63l3m+QNYgSI6yfVHGWQxkGWaN7gn6ZA+bPhOSyuV?=
 =?us-ascii?Q?gHDpJWxhCQVJUQVEOYmd5mSTYEZZzCrz4R7OxQ1mCnJGgJLbfq8wrYyibBxf?=
 =?us-ascii?Q?slDF3pOoJW1uvwNnuYYc4pSe872myZFixAKKKOK4ME0QHco1eQgqxMLrfjN2?=
 =?us-ascii?Q?gjLZOY0tUBn7UaG7NdCrAj/+vvghgggpCOq6zMge4XlzGwjo/HW0EUMTvfoh?=
 =?us-ascii?Q?4I6p49ebYVWh9/RBPeIKyomJepKHdXkfyUr5LyZ0//0r0JAYpdeFGwAzJgAg?=
 =?us-ascii?Q?yFUggrbIxS+pAQFLTTdr9EQYNDLXmvwxTPFofzdVe5I8urIwexdye1jSdup8?=
 =?us-ascii?Q?e/hmI2376Uf+0OnUOtH8re94Ppo8jsA12TI59zuN+a57tVbwEcD/UD4w+eSz?=
 =?us-ascii?Q?m1VbgjKLZzvDDup8ZE5R/VIRiMny+7X/0lDwvuaaygcO80H8AzLr34zN833s?=
 =?us-ascii?Q?1o6Xdwp6diSCte3lQvpEmzY+yf5oIGb7UVD0pTpS6RgkpiezFa+s6cDZYyaP?=
 =?us-ascii?Q?CoaA0oFH6yF6UGK0xFdNfIUFQDffpl9JezclAVrsHBYXmd5Ug0SvV4UedOus?=
 =?us-ascii?Q?9f5mpa66b7r/N/lpKygGcqXT?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ed9125f-2264-4b43-205b-08d95b1175ba
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 08:41:19.6354
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vpW/kWYbKWC65ZGxc8P0NOdVCNserJdmMPHRRb1OhtTEOC+vuAJwoSdkNisLfHTSwtrkRufmV1s2W6SmEa6suA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4428
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> When a read/write command is sent via ioctl to the kernel,
> and the command fails, the actual error response of the emmc
> is not sent to the user.
>=20
> Following are the tests carried out using commands
> 17 (Single BLock Read),
> 24 (Single Block Write),
> 18 (Multi Block Read),
> 25 (Multi Block Write)
>=20
> The tests are carried out on a 64Gb emmc device. All of these
> tests try to access an "out of range" sector address (0x09B2FFFF).
>=20
> It is seen that without the patch the response received by the user
> is not OUT_OF_RANGE error (R1 response 31st bit is not set) as per
> JEDEC specification. After applying the patch proper response is seen.
>=20
> The user level ioctl testcode for the above commands and their
> respective outputs without and with the patch are shown below:
>=20
> CMD17 (Test Code Snippet):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
>         printf("Forming CMD%d\n", opt_idx);
>         /*  single block read */
>         cmd.blksz =3D 512;
>         cmd.blocks =3D 1;
>         cmd.write_flag =3D 0;
>         cmd.opcode =3D 17;
>         //cmd.arg =3D atoi(argv[3]);
>         cmd.arg =3D 0x09B2FFFF;
>         /* Expecting response R1B */
>         cmd.flags =3D MMC_RSP_SPI_R1 | MMC_RSP_R1 | MMC_CMD_ADTC;
>=20
>         memset(data, 0, sizeof(__u8) * 512);
>         mmc_ioc_cmd_set_data(cmd, data);
>=20
>         printf("Sending CMD%d: ARG[0x%08x]\n", opt_idx, cmd.arg);
>         if(ioctl(fd, MMC_IOC_CMD, &cmd))
>                 perror("Error");
>=20
>         printf("\nResponse: %08x\n", cmd.response[0]);
>=20
> CMD17 (Output without patch):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> test@test-LIVA-Z:~$ sudo ./mmc cmd_test /dev/mmcblk0 17 09B2FFFF
No need for arg 3 - you are hardcoded overriding it.

> Entering the do_mmc_commands:Device: /dev/mmcblk0 nargs:4
> Entering the do_mmc_commands:Device: /dev/mmcblk0 options[17,
> 0x09B2FFF]
> Forming CMD17
> Sending CMD17: ARG[0x09b2ffff]
> Error: Connection timed out
>=20
> Response: 00000000  (Wrong response)
>=20
> CMD17 (Output with patch):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> test@test-LIVA-Z:~$ sudo ./mmc cmd_test /dev/mmcblk0 17 09B2FFFF
> [sudo] password for test:
> Entering the do_mmc_commands:Device: /dev/mmcblk0 nargs:4
> Entering the do_mmc_commands:Device: /dev/mmcblk0 options[17, 09B2FFFF]
> Forming CMD17
> Sending CMD17: ARG[0x09b2ffff]
> Error: Connection timed out
>=20
> Response: 80000900
> (Correct OUT_OF_ERROR response as per JEDEC specification)


>=20
> CMD24 (Test Code Snippet):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
>         printf("Forming CMD%d\n", opt_idx);
>         cmd.opcode =3D 24;
>         //cmd.arg =3D atoi(argv[3]);
>         cmd.arg =3D 0x09B2FFFF;
>         cmd.flags =3D MMC_RSP_R1 | MMC_CMD_ADTC;
>         cmd.blksz =3D 512;
>         cmd.blocks =3D 1;
>         cmd.write_flag =3D 1;
>=20
>         memset(data, 0xA5, sizeof(__u8) * 512);
>         mmc_ioc_cmd_set_data(cmd, data);
>=20
>         printf("Sending CMD%d: ARG[0x%08x]\n", opt_idx, cmd.arg);
>         if(ioctl(fd, MMC_IOC_CMD, &cmd))
>                 perror("Error");
>=20
>         printf("\nResponse: %08x\n", cmd.response[0]);
>=20
> CMD24 (Output without patch):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> test@test-LIVA-Z:~$ sudo ./mmc cmd_test /dev/mmcblk0 24 0x09B2FFF
> [sudo] password for test:
> Entering the do_mmc_commands:Device: /dev/mmcblk0 nargs:4
> Entering the do_mmc_commands:Device: /dev/mmcblk0 options[24,
> 0x09B2FFF]
> Forming CMD24
> Sending CMD24: ARG[0x09b2ffff]
> Error: Connection timed out
>=20
> Response: 00000000 (Incorrect response)
>=20
> CMD24 (Output with patch):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> test@test-LIVA-Z:~$ sudo ./mmc cmd_test /dev/mmcblk0 24 09B2FFFF
> Entering the do_mmc_commands:Device: /dev/mmcblk0 nargs:4
> Entering the do_mmc_commands:Device: /dev/mmcblk0 options[24, 09B2FFFF]
> Forming CMD24
> Sending CMD24: ARG[0x09b2ffff]
> Error: Connection timed out
>=20
> Response: 80000900
> (Correct OUT_OF_RANGE response as per JEDEC specification)
>=20
> CMD18 (Test Code Snippet):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
>         printf("Forming CMD%d\n", opt_idx);
>=20
>         cmd.blksz =3D 512;
>         cmd.blocks =3D 1;
>         cmd.write_flag =3D 0;
>         cmd.opcode =3D 18;
>         //cmd.arg =3D atoi(argv[3]);
>         cmd.arg =3D 0x09B2FFFF;
>=20
>         cmd.flags =3D MMC_RSP_SPI_R1 | MMC_RSP_R1 | MMC_CMD_ADTC;
>=20
>         memset(data, 0, sizeof(__u8) * 512);
>         mmc_ioc_cmd_set_data(cmd, data);
>=20
>         printf("Sending CMD%d: ARG[0x%08x]\n", opt_idx, cmd.arg);
>         if(ioctl(fd, MMC_IOC_CMD, &cmd)) {
>                 printf(" error ioctl \n");
>                 perror("Error");
>         }
>=20
>         printf("\nResponse: %08x\n", cmd.response[0]);
>=20
> CMD18 (Output without patch):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> test@test-LIVA-Z:~$ sudo ./mmc cmd_test /dev/mmcblk0 18 0x09B2FFF
> Entering the do_mmc_commands:Device: /dev/mmcblk0 nargs:4
> Entering the do_mmc_commands:Device: /dev/mmcblk0 options[18,
> 0x09B2FFF]
> Forming CMD18
> Sending CMD18: ARG[0x09b2ffff]
>  error ioctl
> Error: Connection timed out
>=20
> Response: 00000000 (Incorrect response)
>=20
> CMD18 (Output with patch):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> test@test-LIVA-Z:~$ sudo ./mmc cmd_test /dev/mmcblk0 18 09B2FFFF
> Entering the do_mmc_commands:Device: /dev/mmcblk0 nargs:4
> Entering the do_mmc_commands:Device: /dev/mmcblk0 options[18, 09B2FFFF]
> Forming CMD18
> Sending CMD18: ARG[0x09b2ffff]
>  error ioctl
> Error: Connection timed out
>=20
> Response: 80000900
> (Correct OUT_OF_RANGE response as per JEDEC specification)
>=20
> CMD25 (Test Code Snippet):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
>         printf("Forming CMD%d\n", opt_idx);
>         cmd.opcode =3D 25;
>         //cmd.arg =3D atoi(argv[3]);
>         cmd.arg =3D 0x09B2FFFF;
>         cmd.flags =3D MMC_RSP_R1 | MMC_CMD_ADTC;
>=20
>         cmd.blksz =3D 512;
>         cmd.blocks =3D 1;
>         cmd.write_flag =3D 1;
>=20
>         memset(data, 0xA5, sizeof(__u8) * 512);
>         mmc_ioc_cmd_set_data(cmd, data);
>=20
>         printf("Sending CMD%d: ARG[0x%08x]\n", opt_idx, cmd.arg);
>         if(ioctl(fd, MMC_IOC_CMD, &cmd)) {
>                 printf("\nerror ioctl\n");
>                 perror("Error");
>         }
>=20
>         printf("\nResponse: %08x\n", cmd.response[0]);
>=20
> CMD25 (Output without patch):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> test@test-LIVA-Z:~$ sudo ./mmc cmd_test /dev/mmcblk0 25 0x09B2FFF
> Entering the do_mmc_commands:Device: /dev/mmcblk0 nargs:4
> Entering the do_mmc_commands:Device: /dev/mmcblk0 options[25,
> 0x09B2FFF]
> Forming CMD25
> Sending CMD25: ARG[0x09b2ffff]
>=20
> error ioctl
> Error: Connection timed out
>=20
> Response: 00000000 (Incorrect response)
>=20
> CMD25 (Output with patch):
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> test@test-LIVA-Z:~$ sudo ./mmc cmd_test /dev/mmcblk0 25 09B2FFFF
> Entering the do_mmc_commands:Device: /dev/mmcblk0 nargs:4
> Entering the do_mmc_commands:Device: /dev/mmcblk0 options[25, 09B2FFFF]
> Forming CMD25
> Sending CMD25: ARG[0x09b2ffff]
>=20
> error ioctl
> Error: Connection timed out
>=20
> Response: 80000900
> (Correct OUT_OF_RANGE response as per JEDEC specification)
>=20
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
> Changes in v2:
>   - Make commit message clearer by adding test cases as outputs
A little overwhelming IMO

>=20
>  drivers/mmc/core/block.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index a9ad9f5fa9491..efa92aa7e2368 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -522,11 +522,13 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card
> *card, struct mmc_blk_data *md,
>         if (cmd.error) {
>                 dev_err(mmc_dev(card->host), "%s: cmd error %d\n",
>                                                 __func__, cmd.error);
> +               memcpy(&idata->ic.response, cmd.resp, sizeof(cmd.resp));
>                 return cmd.error;
>         }
>         if (data.error) {
>                 dev_err(mmc_dev(card->host), "%s: data error %d\n",
>                                                 __func__, data.error);
> +               memcpy(&idata->ic.response, cmd.resp, sizeof(cmd.resp));
>                 return data.error;
>         }
>=20
> --
> 2.17.1