Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/5] mm: gup: remove set but unused local variable major
To:     Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc:     imbrenda@linux.ibm.com, kirill.shutemov@linux.intel.com,
        jack@suse.cz, jhubbard@nvidia.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20210807093620.21347-1-linmiaohe@huawei.com>
 <20210807093620.21347-2-linmiaohe@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
Message-ID: <896f0f85-364b-1678-5a3e-d32552e9827c@redhat.com>
Date:   Mon, 9 Aug 2021 11:21:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210807093620.21347-2-linmiaohe@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07.08.21 11:36, Miaohe Lin wrote:
> Since commit a2beb5f1efed ("mm: clean up the last pieces of page fault
> accountings"), the local variable major is unused. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   mm/gup.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 77150624f77a..430495cb1b91 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1276,7 +1276,7 @@ int fixup_user_fault(struct mm_struct *mm,
>   		     bool *unlocked)
>   {
>   	struct vm_area_struct *vma;
> -	vm_fault_t ret, major = 0;
> +	vm_fault_t ret;
>   
>   	address = untagged_addr(address);
>   
> @@ -1296,7 +1296,6 @@ int fixup_user_fault(struct mm_struct *mm,
>   		return -EINTR;
>   
>   	ret = handle_mm_fault(vma, address, fault_flags, NULL);
> -	major |= ret & VM_FAULT_MAJOR;
>   	if (ret & VM_FAULT_ERROR) {
>   		int err = vm_fault_to_errno(ret, 0);
>   
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb