Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Shaun Tancheff <shaun@tancheff.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>
CC:     Damien Le Moal <Damien.LeMoal@wdc.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        Aravind Ramesh <Aravind.Ramesh@wdc.com>,
        Adam Manzanares <a.manzanares@samsung.com>,
        Himanshu Madhani <himanshu.madhani@oracle.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v4 1/2] blk-zoned: allow zone management send operations
 without CAP_SYS_ADMIN
Thread-Topic: [PATCH v4 1/2] blk-zoned: allow zone management send operations
 without CAP_SYS_ADMIN
Thread-Index: AQHXjQP30Hf+JHmZnUepZZSsUIhsww==
Date:   Mon, 9 Aug 2021 09:50:20 +0000
Message-ID: <20210809094855.6226-2-Niklas.Cassel@wdc.com>
References: <20210809094855.6226-1-Niklas.Cassel@wdc.com>
In-Reply-To: <20210809094855.6226-1-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?hM+Zm1F1noi90Pb5IyA5SXGgX5CIqkcnmCOw1slsEACP+aPCxi04Nfd9sZ?=
 =?iso-8859-1?Q?yB96ct5OEELz7a7cKRs4DNbY8b7VX6vbl232ndWQguK8P6kNEQD2qwdcQO?=
 =?iso-8859-1?Q?lGiUontVwG6Rh1TreKlAV6zpRByIzej3w733L2QtDjbCznBdNzNZnjqYGP?=
 =?iso-8859-1?Q?GF8+dfcS11wNo8g3iLXyUZi64nPT5NA0B6X79Ka76TEs4vLtxb+bKkunhT?=
 =?iso-8859-1?Q?xQEO13VpM4SmEMNpXtazB7t0/CUYNl9ikTRVzD4bhZanri+pachprx9PB+?=
 =?iso-8859-1?Q?JSENvMsm9nFKQr4A4+Ies9j3om1U0Yfg0EhbNez0QcNlQc0rhGYNKsbP0Y?=
 =?iso-8859-1?Q?xGIf7HzNOaYGzXhGtOgKVB6j3O5SxbJFeiCvAEG9V6SC7PBIkXSMoRzI3M?=
 =?iso-8859-1?Q?uJ5J7Pt+kG6y2/Ze7T1rzA2C70pQHPm+cQ8vM47/dbHca4r+LCqlGRu5SK?=
 =?iso-8859-1?Q?VllVWZ8zQYzKII2/AiW0IWvJ6XL4o+b/N4NufHpzpU3LPbveCBjrn/RPHK?=
 =?iso-8859-1?Q?Vsm69EUsiMeH4H6AO8umLW9FDwQ+/W/cLsps77wkp2B7jtrM12h6KvU/Ge?=
 =?iso-8859-1?Q?SRTMbAEK2vJW92Vn0enQntEsGJT2ajOYvikeOHkE/FCd88EfcMAqHigRro?=
 =?iso-8859-1?Q?rM3vNobLGKvaWie1UnRUHD/oHzpCf08KaN7xjMCWDNJiR7u1VNfrRNg7bW?=
 =?iso-8859-1?Q?kfbWbt85IkU+HDoZq+coZXIjvXwDiupVDNjdLpOobHcByiNTyCLxyBm3Yy?=
 =?iso-8859-1?Q?8eIGgSRdfDwCFEUv5GZeR7DORmt5gdQ6Lp3yE3n3RA2QoKFYkvkAhMWNV8?=
 =?iso-8859-1?Q?Za7ONjZrkOekTK7eqfn3r/WOfB2USzUBmk2gJ9VGD9ZAux11SKdNRtXqxR?=
 =?iso-8859-1?Q?gr2uZtpRGfGRzF9g55K7yUhlsbUR/RwZ0BpQsDpjPm6AhnNtqF01echwj3?=
 =?iso-8859-1?Q?UfotHWLz/+JC9ops/nVbUaX3Pih9SL1ia9+W/QkmaBg3ig0NGuIBh92Z/R?=
 =?iso-8859-1?Q?+raCcDP5OYYbE2u6riXutpf2lbXzf/MtO+2Lf1jlhwENLphzC9JtANzSYC?=
 =?iso-8859-1?Q?0H+nJLWX/5F/zYHpHn03yzIwRsjS9LN9YS/c1NhV2p8Z7O0bsIK79PlWvc?=
 =?iso-8859-1?Q?eamupRBmL8N4mwX/Y1vyCJYWBjGStm1PHV9jwflZTwL4TQUQFRdSoYWFzm?=
 =?iso-8859-1?Q?9gk4ePdsqJ5emogu0DJZenluv1ldPAu4h2dYl5gSn0YQJRImuB6hTbJLsm?=
 =?iso-8859-1?Q?8NP/h0E5HIOoB1ldwbicltJdPKgX73sbH9+S1oCUTTJp+94Hly59P+9f3c?=
 =?iso-8859-1?Q?GWKUyRo5QxTW+JEuSYgFQGf7Y88WPohQVksQAEj+MezT36kJZOQRxuv73A?=
 =?iso-8859-1?Q?jciJcdVVXF?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1fa41ba-84a1-410b-aeae-08d95b1b1bd4
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 09:50:20.9193
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QK6+O1wL1IZv4BRP8C9cayZP5gTaRfWQo9UIeRe+P5paoKhNcfxx4ZeJz+lSSkBhr7ye0Fu0JqA1cXTceuHWAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7558
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Niklas Cassel <niklas.cassel@wdc.com>

Zone management send operations (BLKRESETZONE, BLKOPENZONE, BLKCLOSEZONE
and BLKFINISHZONE) should be allowed under the same permissions as write().
(write() does not require CAP_SYS_ADMIN).

Additionally, other ioctls like BLKSECDISCARD and BLKZEROOUT only check if
the fd was successfully opened with FMODE_WRITE.
(They do not require CAP_SYS_ADMIN).

Currently, zone management send operations require both CAP_SYS_ADMIN
and that the fd was successfully opened with FMODE_WRITE.

Remove the CAP_SYS_ADMIN requirement, so that zone management send
operations match the access control requirement of write(), BLKSECDISCARD
and BLKZEROOUT.

Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Aravind Ramesh <aravind.ramesh@wdc.com>
Reviewed-by: Adam Manzanares <a.manzanares@samsung.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: stable@vger.kernel.org # v4.10+
---
Changes since v3:
-Picked up additional Reviewed-by tags.

Note to backporter:
Function was added as blkdev_reset_zones_ioctl() in v4.10.
Function was renamed to blkdev_zone_mgmt_ioctl() in v5.5.
The patch is valid both before and after the function rename.

 block/blk-zoned.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 86fce751bb17..8a60dbeb44be 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -421,9 +421,6 @@ int blkdev_zone_mgmt_ioctl(struct block_device *bdev, f=
mode_t mode,
 	if (!blk_queue_is_zoned(q))
 		return -ENOTTY;
=20
-	if (!capable(CAP_SYS_ADMIN))
-		return -EACCES;
-
 	if (!(mode & FMODE_WRITE))
 		return -EBADF;
=20
--=20
2.31.1