Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Jens Axboe <axboe@kernel.dk>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Hannes Reinecke <hare@suse.com>,
        Shaun Tancheff <shaun@tancheff.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     Damien Le Moal <Damien.LeMoal@wdc.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        Damien Le Moal <damien.lemoal@dc.com>,
        Aravind Ramesh <Aravind.Ramesh@wdc.com>,
        Adam Manzanares <a.manzanares@samsung.com>,
        Himanshu Madhani <himanshu.madhani@oracle.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v4 2/2] blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN
Thread-Topic: [PATCH v4 2/2] blk-zoned: allow BLKREPORTZONE without
 CAP_SYS_ADMIN
Thread-Index: AQHXjQP4aNCn2fw5YUWhEgczWRLRaw==
Date:   Mon, 9 Aug 2021 09:50:21 +0000
Message-ID: <20210809094855.6226-3-Niklas.Cassel@wdc.com>
References: <20210809094855.6226-1-Niklas.Cassel@wdc.com>
In-Reply-To: <20210809094855.6226-1-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?jzXj/YMya20Fb4wBZpYJS4GyCi8wuzrcc15ZveCz1F/fDRUHSlsSiisxBw?=
 =?iso-8859-1?Q?UwHAS4KBrCDeAV53xZRo/0LdKGApmA6BYmAeMBQuTnlls1r+LuO8hBrObz?=
 =?iso-8859-1?Q?icyKD7xmBlSbDeORLS0R2v6W0RZkG9+7WLNGjkCV7AeAts33fQscRqkCBf?=
 =?iso-8859-1?Q?s4at+C2SxKaJgzwi1fYRwNSKDIC+T98UXmowSiLbC7QLhDL+GZaK+9lg1M?=
 =?iso-8859-1?Q?pLKE77gmqieHsmLVO6wGknJqKPwawaSSjggioG0AcpqGdPyNmnBTaYAopk?=
 =?iso-8859-1?Q?+/2cpEdWXkPSxpnNocqzPlsC+EsA5Q5Ur9JP9drZFwgxJY6rH22isVez9e?=
 =?iso-8859-1?Q?r5GPUpoav+hypzXGFXDRw4lzsIdpeZToPOZkS1J7ndDz9byxPiDyclLv0G?=
 =?iso-8859-1?Q?lLtSIFUYmxQ0vcgn7EnpjvITLlMy6u0aXA7I5Whwgw7VN/rPYVbGLX2jgk?=
 =?iso-8859-1?Q?QRJLN6fugEhoOzFK1OvIn99j+opbLFD1ujbPs5Uwj/T+kXdnYRfDIiQkKg?=
 =?iso-8859-1?Q?paz8Pfp9yNDKjrJBYJAXEVcUrHST1KJSoKOc0YpZAAOd6otU+Mm3cwhGEy?=
 =?iso-8859-1?Q?1g+i1/fQXOovoewCqmFSn+lHP8E08ICgbDdDuKnLnhZdPIS/hMmXbEIe9H?=
 =?iso-8859-1?Q?4Cv+wsvkO35um77krE8If3U320n83HpYj0BHPrbomRlPDJ6wIL2fG6k/6H?=
 =?iso-8859-1?Q?9I7sdg/x1kgZaRH/zMQldK9HlbpIu2FUg6zAnspc1n1ShO5l7z0vPo2MKn?=
 =?iso-8859-1?Q?hXdp4DpV7lhPaxxhpolxNVy9onOwtEyS1FcdDBrXtQn1hY9Xr/AHSM7HJJ?=
 =?iso-8859-1?Q?jYJKUalSBAmPqW8703c01coiNqW9tcI6aSS27UHxD7CI8gqFb/qWqaY9GY?=
 =?iso-8859-1?Q?YkFMiftlmk1lvJ6jmWNBBV4SaxtwudrVj/6N8CcDWP1wyEmJHQDTRNbHBq?=
 =?iso-8859-1?Q?r1U7wiR+Q7jf5kF+0vcG81bELY8OaCiJYSG9AmltgxI2H5oV9D66EUu1Nc?=
 =?iso-8859-1?Q?+JpJ3uOvJYKtaLuzODBM3XLE+IqzvY137AOWrpbegJA5Mcpsl9nh9grqa1?=
 =?iso-8859-1?Q?qKJjeK+hFR7302e+PvkPKehwpOl1dRVmITpsRS2R+L0fm19gY9bwgXohLJ?=
 =?iso-8859-1?Q?+66OpIgUXuMtYrUkTu1db0HJ4pjzXAAp+oZ5uXX53lt4JZiLpMB+VCNCEK?=
 =?iso-8859-1?Q?DnvIxhkiiJABWb2r10zBXrAt+UQU+c6UjpxwHqIU3iEkq6tpU1JWXf15BY?=
 =?iso-8859-1?Q?ayelo3g0NYpwOCah8M3gU3eZq3M7qQUKcA1sLs8OPXW35Q/TE48dIYYoNm?=
 =?iso-8859-1?Q?IwrFzyqays7Lq/CdgU6Mtw1SvGty+cFQrE7LKGHB9CypBExcP/dXHpwgPh?=
 =?iso-8859-1?Q?l9oEaRgCn3?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63dae971-40ef-43dd-58b7-08d95b1b1c01
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 09:50:21.6700
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pfw5d+xjd19gyHFSWcdG1Rg2pIRS1tgX/+9G6qSPPQf+Lzq3AogUPcoxk0wwysMoDsOTtj4sKzdrxAorCX3XlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7558
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Niklas Cassel <niklas.cassel@wdc.com>

A user space process should not need the CAP_SYS_ADMIN capability set
in order to perform a BLKREPORTZONE ioctl.

Getting the zone report is required in order to get the write pointer.
Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable
that a user space process that can read/write from/to the device, also
can get the write pointer. (Since e.g. writes have to be at the write
pointer.)

Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@dc.com>
Reviewed-by: Aravind Ramesh <aravind.ramesh@wdc.com>
Reviewed-by: Adam Manzanares <a.manzanares@samsung.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: stable@vger.kernel.org # v4.10+
---
Changes since v3:
-Picked up additional Reviewed-by tags.

 block/blk-zoned.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 8a60dbeb44be..1d0c76c18fc5 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -360,9 +360,6 @@ int blkdev_report_zones_ioctl(struct block_device *bdev=
, fmode_t mode,
 	if (!blk_queue_is_zoned(q))
 		return -ENOTTY;
=20
-	if (!capable(CAP_SYS_ADMIN))
-		return -EACCES;
-
 	if (copy_from_user(&rep, argp, sizeof(struct blk_zone_report)))
 		return -EFAULT;
=20
--=20
2.31.1