Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp2624303pxt; Mon, 9 Aug 2021 05:15:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2KY5wF1Evf34HslewxVOOyCpdzijJ7c3Uhok6/2Dz2h/1WrxJGJOy+4+dpEESnOrol++E X-Received: by 2002:a50:da0e:: with SMTP id z14mr29702151edj.73.1628511310586; Mon, 09 Aug 2021 05:15:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628511310; cv=none; d=google.com; s=arc-20160816; b=O7FD5LCLviOokeUJPH3Aq2mmAYEfzzggR6HBXmqdcVEVGXIkoBhJe3sEjYMWgiubnk 7ZyPlgtOTpDqNfQm0YKNNgo5oZYlNRWfxRDvdzb1LMZXMkEiUx+Ox8Ujd3FX56cr6DKa X9gG5gfaR7KQeT4KRtg/r3pnA+6IH5bNj+T1aq13/HwT0WxxXtxH84pX2nPDnXNcECHP d/MF+1/OneLmT+ywMIxS5j+AZmcaLXQyLm16eVJvA5HH1eEP7cY0jm+n4VjG62qnq65n Od8r0dTMA6uhXcUollQs5F9EO0bFIBqGMdbqXBbLpVXM0LShjwPaDsxYfobpR7lqKDjE /8UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=YlxCbW/CqcLdARJnlAirPQnky4qavkVOaD/Fdc4p0TY=; b=BEvFFuNT4lZ11kv5Ryckhl4u9SYrZyutN9jkp7kM5lHe/1dddsPc7d5260tDZAfFTk 6Vq0AJ3MVK8YaVNF0GoVvcgt16PhJO+QtpsF64NwQgHDk1taEWdumaEeZQ5Pq8g9r3Oe 5ZEH+HncSP5yYN33viPSse5MYseiDiZ0vs6wpNC9ZPxZ++27uyS0NFTHtUeo7OGno/Vu TKlhN+f58TEHwm9qQ/owCW4W56ID8dXqgEsXMxX+EIEYAwmFnAO6LEBWFdC+xzNyU7JP 68wKdU6cUk1rIGEWLmzvEmlDGV4qDI5uRSJJyU5QqJrqreoS9Zom4HKtoIIhis1TP+eE WzTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=EKnNwZ8Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x8si15905342eju.237.2021.08.09.05.14.46; Mon, 09 Aug 2021 05:15:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=EKnNwZ8Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234619AbhHIJkR (ORCPT + 99 others); Mon, 9 Aug 2021 05:40:17 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58610 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234365AbhHIJkR (ORCPT ); Mon, 9 Aug 2021 05:40:17 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1799Yibd128990; Mon, 9 Aug 2021 05:39:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=YlxCbW/CqcLdARJnlAirPQnky4qavkVOaD/Fdc4p0TY=; b=EKnNwZ8Ynw/Wt1pm0WhC/+lAbmzp1q09dlhdx12oaTmCpKrZzd0SuCq/FgwJxjXjp+0M bBnLaaKeirZxKrRX2D/mBEJMktLVJGm0inv9dE2fTjOp459vALetV8tlO7X4CeER8wNf cHaUC1tHeuU7DZXYIafxYZ1zncLp5u+l/g6cy0/t+paFfCuA0mJW/GPzC1JRndlM31JU L3Lbijb8x8sF/5QJi1e1joKn161Writ2+m/gZ2zAtejxpq4Bh7OIjmR81RsBfWXUH8HK Fj00JbUdZBEb64W2i0GHpmKrcDWzuqLC4Jr4hjyxi8GmoXdC3SVSo7TLlyTB+1FfhdN8 GA== Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 3aaa1qr6nw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Aug 2021 05:39:46 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1799ckKQ020162; Mon, 9 Aug 2021 09:39:45 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma02fra.de.ibm.com with ESMTP id 3a9ht8bbsq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Aug 2021 09:39:44 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1799dgg756492520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 Aug 2021 09:39:42 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03F3111C058; Mon, 9 Aug 2021 09:39:42 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A07711C06F; Mon, 9 Aug 2021 09:39:41 +0000 (GMT) Received: from p-imbrenda (unknown [9.145.6.223]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 9 Aug 2021 09:39:41 +0000 (GMT) Date: Mon, 9 Aug 2021 11:39:38 +0200 From: Claudio Imbrenda To: Miaohe Lin Cc: , , , , , Subject: Re: [PATCH 0/5] Cleanups and fixup for gup Message-ID: <20210809113938.3c116c78@p-imbrenda> In-Reply-To: <20210807093620.21347-1-linmiaohe@huawei.com> References: <20210807093620.21347-1-linmiaohe@huawei.com> Organization: IBM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: KUGqpINfKHIjWaAaVhyoh71Q2QkTZ_AV X-Proofpoint-ORIG-GUID: KUGqpINfKHIjWaAaVhyoh71Q2QkTZ_AV X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-09_01:2021-08-06,2021-08-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=924 mlxscore=0 clxscore=1011 spamscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108090075 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 7 Aug 2021 17:36:15 +0800 Miaohe Lin wrote: > Hi all, > This series contains cleanups to remove unneeded variable, useless > BUG_ON and use helper to improve readability. Also we fix a potential > pgmap refcnt leak. More details can be found in the respective > changelogs. Thanks! > > Miaohe Lin (5): > mm: gup: remove set but unused local variable major > mm: gup: remove unneed local variable orig_refs > mm: gup: remove useless BUG_ON in __get_user_pages() > mm: gup: fix potential pgmap refcnt leak in __gup_device_huge() > mm: gup: use helper PAGE_ALIGNED in populate_vma_page_range() > > mm/gup.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > Whole series (including the fixup for the return value): Reviewed-by: Claudio Imbrenda