Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp2644255pxt; Mon, 9 Aug 2021 05:44:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoosPAHvksDzcdPhZ0+wv3/01g/aqGguZ2VCuVIVCzKGJF3DNZFKyhWzJArwr3/1g7PG/4 X-Received: by 2002:aa7:d511:: with SMTP id y17mr29741967edq.341.1628513049158; Mon, 09 Aug 2021 05:44:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628513049; cv=none; d=google.com; s=arc-20160816; b=DvQQMeLJ+nHS65DKwwvPLugmw3mEf4QMFgLgBZkF//UP/Rm/WiWVL5Ajhgv4wAQOZw tmCLFVrz09f/nIuoE7oaplKHXQhOxuJ9n5byRNeAs1f1QxqiV0x5EP2QmjDCbXIt/CqW 99wEytG4aGfb4wETNEaAnxcMTE6ADlhTqwxoRDq/13JrYrFS0TuJUC5j6EfKtIwcP9TU sCkT/wTFQtTxoyoBbL878tRsesqw0L6k0oip0Jx9nKsdsP30ZIIhggVjf3S6g8bhzqoU 8/riuYsLvGK95HDQ0CDJTUbAlXFTZGWXImEM54/CbNOGtv531LOg9FUebjLJ3XPOMMtn E5dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=0zVmmfKjsh0O6iTcBeLVuCbww8hMd82b9Le3k2jDVtU=; b=B+nYOS2FlMNvXAwvokTyXaK0hbSdVqD/PSuTwoU43N8Vw3ZB/7aiLFk3AvAzWyM7mZ GweZwBqE+pV/wIuOFvtBtduN6LPSjMInx0adYT2rb3kwxB0uMUdNllsObFAdkp1pzSNq 8PvRHnjmYjlDL//BTdhsP44mQcTAA3MO3S3BHpkRBeYGOaf6OTE9dbnHtPL3v+qZSS4G XPUvLyGWzOxrYwWkKkZxmWkKNHCikZlqzK5wXuxdYLx1EQCkalfSfjGjjBjsJzfMXwT8 /16SJo8SvedQVvzKGhBLtCYINuQ4+EPnJfFwXsO7K5argJQ/vpYQLh6sD6DuOAoWxtpb /Wfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IeN4102E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id el10si4383671ejc.171.2021.08.09.05.43.46; Mon, 09 Aug 2021 05:44:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IeN4102E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235390AbhHIMOW (ORCPT + 99 others); Mon, 9 Aug 2021 08:14:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235095AbhHIMOQ (ORCPT ); Mon, 9 Aug 2021 08:14:16 -0400 Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3693C0613D3 for ; Mon, 9 Aug 2021 05:13:55 -0700 (PDT) Received: by mail-ua1-x92a.google.com with SMTP id v3so6900614uau.3 for ; Mon, 09 Aug 2021 05:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0zVmmfKjsh0O6iTcBeLVuCbww8hMd82b9Le3k2jDVtU=; b=IeN4102EglVq6qp9hh2HqtonBYVIky9VwVBQB6Gvbk+p1dYiI/3JCTZFyt6RjAOCVv SqVs6vpO9EUQgvDdFVlfIjUDD8jC9JEHJ0k6yvutzVOurcWoI/mtDoElrZnSG6JWdYeq OsIuCcaSyg1a4ujJK5zzLSSHRi3Ybw8Pv50hFnG9kLxd9oEq/cs984/0nNA3VJnGH4w0 +ikRhA9yD6YgAOxn2aGfVdKuastyUfRBd215VG7V9YBL3ivYajvZSTNHdD8y6ZKW3J+U ZPIjod43oKSb14ICuisE/yhq+7hHgX0/Hcns0tK7u2E45Uk8dDBL2btJraHiPbaGp/EV sIXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0zVmmfKjsh0O6iTcBeLVuCbww8hMd82b9Le3k2jDVtU=; b=RLqcKf8ICg/qyQptkmQWJxtfIQMWrso+3OOzHxYloCP+wvq+ZLkt2LgV2JIwPQTxkh crkO20dfY30ZG0pDrOigFEWFC38HHkN0Qq9i3Ev+b6dawqn4mPPfvCdBRjKb6zqSQOYB xGBFSDsciRPvDhHh5eKPrDrqfpG153Gihtn5HMdmf1LxzdOAkOaiuILb+gpM4n1gV+AG Mrl4w0vNLrnjICB0rTk3bpK3M+cZOaZio4YY+yLZslxNcm/+h4Gx+bXZ8CXMZUcA8f6x CCmsa9bRfurSCJXeL7mehKDS7Ju5NfmtwhEe6mPE0cr2ZGr6ZiRPN8cRxYstAx/cVgFw yXfw== X-Gm-Message-State: AOAM5315TbcsmAwZSPda3keeUIv/BY3fqKplRnsWzsuyvQ8PLEQiUnkj xmRd+EVh3P1WkaIS0nWQSJuhli+4e+lFb1KM0kUvvg== X-Received: by 2002:a9f:25a7:: with SMTP id 36mr14751050uaf.129.1628511234750; Mon, 09 Aug 2021 05:13:54 -0700 (PDT) MIME-Version: 1.0 References: <20210730063309.8194-1-rashmi.a@intel.com> <20210730063309.8194-3-rashmi.a@intel.com> In-Reply-To: From: Ulf Hansson Date: Mon, 9 Aug 2021 14:13:18 +0200 Message-ID: Subject: Re: [PATCH 2/3] mmc: sdhci-of-arasan: Add intel Thunder Bay SOC support to the arasan eMMC driver To: "A, Rashmi" Cc: Vinod Koul , Michal Simek , linux-mmc , Linux ARM , Linux Kernel Mailing List , Kishon , Andy Shevchenko , "linux-phy@lists.infradead.org" , Mark Gross , "kris.pan@linux.intel.com" , "Zhou, Furong" , "Sangannavar, Mallikarjunappa" , "Hunter, Adrian" , "Vaidya, Mahesh R" , "Srikandan, Nandhini" , "Demakkanavar, Kenchappa" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Aug 2021 at 13:17, A, Rashmi wrote: > > > > > -----Original Message----- > > From: Vinod Koul > > Sent: Monday, August 9, 2021 2:12 PM > > To: A, Rashmi > > Cc: Ulf Hansson ; Michal Simek > > ; linux-mmc ; Linux > > ARM ; Linux Kernel Mailing List > kernel@vger.kernel.org>; Kishon ; Andy Shevchenko > > ; linux-phy@lists.infradead.org; Mark > > Gross ; kris.pan@linux.intel.com; Zhou, Furong > > ; Sangannavar, Mallikarjunappa > > ; Hunter, Adrian > > ; Vaidya, Mahesh R > > ; Srikandan, Nandhini > > ; Demakkanavar, Kenchappa > > > > Subject: Re: [PATCH 2/3] mmc: sdhci-of-arasan: Add intel Thunder Bay SOC > > support to the arasan eMMC driver > > > > On 09-08-21, 05:16, A, Rashmi wrote: > > > > > > > > > > Rashmi, is it safe to apply this separately from the phy driver/dt changes? > > > > Then I can queue this via my mmc tree, if you like. > > > No, the phy driver/dt changes must go together with "mmc: sdhci-of- > > arasan: Add intel Thunder Bay SOC support to the arasan eMMC driver" > > patch. > > > > Why is that? > > > > What could happen, emmc driver will complain about phy not found and bail > > right? > This is right, but ideally both mmc:phy and mmc: sdhci-of-arasan driver code changes should go together If patches are well written and can be standalone, we (maintainers) ideally prefer to queue things on a per subsystem basis, because it's just easier. That said, I also noticed that a new compatible string was added, "intel,thunderbay-sdhci-5.1". This needs to be documented in Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml, in a separate patch, preceding $subject patch. Kind regards Uffe