Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: luoj=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DD19CC433D3
Subject: Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org, davem@davemloft.net,
        kuba@kernel.org, robh+dt@kernel.org, robert.marko@sartura.hr,
        linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        sricharan@codeaurora.org
References: <20210808075328.30961-1-luoj@codeaurora.org>
 <YQ/8q6gR6Eji2hKD@lunn.ch>
From:   Jie Luo <luoj@codeaurora.org>
Message-ID: <ba6f3daa-7b1c-dd66-f803-c049e1fc3e8a@codeaurora.org>
Date:   Mon, 9 Aug 2021 21:06:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YQ/8q6gR6Eji2hKD@lunn.ch>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 8/8/2021 11:47 PM, Andrew Lunn wrote:
> On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote:
>> The new added properties resource "reg" is for configuring
>> ethernet LDO in the IPQ5018 chipset, the property "clocks"
>> is for configuring the MDIO clock source frequency.
>>
>> This patch depends on the following patch:
>> Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO
>> driver")
> Please always make binding patches part of the series containing the
> driver code. We sometimes need to see both to do a proper review.
>
> Add a comment about when the second address range and clock is
> required. Does qcom,ipq5018-mdio require them?
>
> 	  Andrew

Hi Andrew,

yes, the second address range is only required for qcom,ipq5018-mdio 
currently,

will document it in next patch set, and send it with the drive code 
patch, thanks

for the comments and review.