Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
To:     Tuo Li <islituo@gmail.com>,
        "Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
        "dledford@redhat.com" <dledford@redhat.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>
CC:     "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "baijiaju1990@gmail.com" <baijiaju1990@gmail.com>,
        TOTE Robot <oslab@tsinghua.edu.cn>
Subject: RE: [PATCH v3] IB/hfi1: Fix possible null-pointer dereference in
 _extend_sdma_tx_descs()
Thread-Topic: [PATCH v3] IB/hfi1: Fix possible null-pointer dereference in
 _extend_sdma_tx_descs()
Thread-Index: AQHXisdVCiYfRycHCkqSzyQ/bPA5dqtrKwdw
Date:   Mon, 9 Aug 2021 13:15:43 +0000
Message-ID: <CH0PR01MB71535B0EAF68AEDAA3D45D97F2F69@CH0PR01MB7153.prod.exchangelabs.com>
References: <20210806133029.194964-1-islituo@gmail.com>
In-Reply-To: <20210806133029.194964-1-islituo@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YISbllA74Fc0t8EqtmNBzbfn5veJi3JT0ee8Yg3K1f7rOuqX56FkTcS+Mi9w?=
 =?us-ascii?Q?KwfuCw6uVb2t1O5LDstOEqj9Suo0/AdRUZ6snUlD1H/ftq5C08NnoBstI/bT?=
 =?us-ascii?Q?NZNiq3wymWlhrS5blelcwaO/CZ0GBcqpWmws0owBRVbsnHsDgD7mtWhviN2H?=
 =?us-ascii?Q?Jqucheb1mp7VI10N/xvJXqN6QOKEh2QNRBmZI/T7E6QAJdGKlFv4e8gFhveI?=
 =?us-ascii?Q?9l1w7YgRcE+11VkiFV1+ci6QHHtWn/zEYTyYWWSzaeydku7tXEjnHGvoajro?=
 =?us-ascii?Q?TX+FL00hZbANdUvJWd91gc9zTTsPZvllfMa9kpRdwZTYuav+u6ktQEWasl4r?=
 =?us-ascii?Q?wdIotha7Ig+ppz0VMrarYacYi99afJG7qpsDpDYweVlIGD/CSQpBsS27CJ/y?=
 =?us-ascii?Q?9qyec9pJyskB4O/Su7Y67W2DRevyToTEJmBJLRSbSQ7RxKtjLqROxCLwVPCI?=
 =?us-ascii?Q?A13/stOFVbBfp7UM+XiBwzuAGqkrz2xV6bZp5kPZ9Rb7Q3WTyCq0wMFKQ++p?=
 =?us-ascii?Q?AS+9sHqPK+lnzCnvUU2vDVGaCSlk2QndZQWKHcuug30KT3vTvxleuQpB7ylb?=
 =?us-ascii?Q?gk7aNczhxJMI+1SYXEwh1NCnDNLCNoTSZyjY4VtBFPeyp2R3x9zi/fPfKeCU?=
 =?us-ascii?Q?/bpmvInE1I22FfLKHtlcZRekg77kYv7a04rUeehOZjgki6n2FvD2ZUzzrasa?=
 =?us-ascii?Q?ve4p2abCofVINp64n3EaSr0McSRMsYHR090iABmZXrVKLpxdXfVVMsiG0cpp?=
 =?us-ascii?Q?FEQo8eksI+yW1gyKYyc2MOyCO9BkwjpoXaX0swdioqpigkE/1KZpgpwNkbXe?=
 =?us-ascii?Q?O8gMEfHp79rxhXrang+sOrgGunJtvJV75YNF/sx829NTwsrk4bzgoE9v1ypA?=
 =?us-ascii?Q?92MiRFP2ajU+HHJRgkrC0uEWsEXyXKWUn3n5fFN0KeiXT+gEwRz+Vq9Wb8GW?=
 =?us-ascii?Q?RcxgyY5ShMvLOOvDBzFeRDuIenuO95Ioa4meSL9mcEmBwbNztwH/BSJAurVN?=
 =?us-ascii?Q?aCDLm89bFJJc9xGt1f3eAQTZOIQpEOccR4jiFZFgQPKUtBdSblimqN/iQxQo?=
 =?us-ascii?Q?3td/sSje6zUAk4gnf91PMGGw7fClPWXblCfrNzE/KHPVGG4bUqkn5bCbg8xh?=
 =?us-ascii?Q?IsmjULgxrxf7SOmgqrBe2coAtxycOpNmaTGBXMrY1Fvbh1R9/AiA17aEDtvE?=
 =?us-ascii?Q?IlOCwAMWRUaxhxHyLe6S+PSKrAoSAaNOYLdZCk05IS1HIlmnxiElvALk/A9Q?=
 =?us-ascii?Q?0fjEUAeYZU7AY3YzxyHtZrTAed2epJu6Wq+NrNu3ZNdqTIejXV7urZ21gDVV?=
 =?us-ascii?Q?ogI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR01MB7153.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2285d03c-3dd0-42b8-edcb-08d95b37cae7
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 13:15:43.4345
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kX55XJN9FaX+3x/7Fb7vPIHgQeDd0iikEtNgZIiZph+3k83gcPCMRp268+2PgNBCe2eE9+Xl8vek3mvlATajJ31yyeVRiRwSoasvh06nL1sujAA4kaLiy+itjeNwWtSQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR01MB5879
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Fixes: 7724105686e7 ("IB/hfi1: add driver files")
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Tuo Li <islituo@gmail.com>
> ---
> v3:
> * Add fixes line.
>   Thank Jason Gunthorpe for helpful advice.
> v2:
> * Assign the return value of kmalloc_array() to a local variable and then=
 check
> it instead of assigning 0 to tx->num_desc when memory allocation fails.
>   Thank Mike Marciniszyn for helpful advice.

Thanks!

I'm curious, did you find this with some fault injection testing?

Tested-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>