Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967766AbWK3BBE (ORCPT ); Wed, 29 Nov 2006 20:01:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S967767AbWK3BBE (ORCPT ); Wed, 29 Nov 2006 20:01:04 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:23890 "EHLO agminet01.oracle.com") by vger.kernel.org with ESMTP id S967766AbWK3BBC (ORCPT ); Wed, 29 Nov 2006 20:01:02 -0500 Date: Wed, 29 Nov 2006 17:01:11 -0800 From: Randy Dunlap To: mingo@redhat.com, lkml Cc: akpm , ak@suse.de Subject: [PATCH -mm] x86_64 UP needs smp_call_function_single Message-Id: <20061129170111.a0ffb3f4.randy.dunlap@oracle.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed version 2.2.9 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1790 Lines: 56 From: Randy Dunlap smp_call_function_single() needs to be visible in non-SMP builds, to fix: arch/x86_64/kernel/vsyscall.c:283: warning: implicit declaration of function 'smp_call_function_single' The (other/trivial) fix (instead of this one) is to add: #include to linux-2.6.19-rc6-mm2/arch/x86_64/kernel/vsyscall.c Signed-off-by: Randy Dunlap --- include/asm-x86_64/smp.h | 7 ------- include/linux/smp.h | 7 +++++++ 2 files changed, 7 insertions(+), 7 deletions(-) --- linux-2.6.19-rc6-mm2.orig/include/asm-x86_64/smp.h +++ linux-2.6.19-rc6-mm2/include/asm-x86_64/smp.h @@ -113,13 +113,6 @@ static __inline int logical_smp_processo #define cpu_physical_id(cpu) x86_cpu_to_apicid[cpu] #else #define cpu_physical_id(cpu) boot_cpu_id -static inline int smp_call_function_single(int cpuid, void (*func) (void *info), - void *info, int retry, int wait) -{ - /* Disable interrupts here? */ - func(info); - return 0; -} #endif /* !CONFIG_SMP */ #endif --- linux-2.6.19-rc6-mm2.orig/include/linux/smp.h +++ linux-2.6.19-rc6-mm2/include/linux/smp.h @@ -99,6 +99,13 @@ static inline int up_smp_call_function(v static inline void smp_send_reschedule(int cpu) { } #define num_booting_cpus() 1 #define smp_prepare_boot_cpu() do {} while (0) +static inline int smp_call_function_single(int cpuid, void (*func) (void *info), + void *info, int retry, int wait) +{ + /* Disable interrupts here? */ + func(info); + return 0; +} #endif /* !SMP */ --- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/