Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp2685594pxt; Mon, 9 Aug 2021 06:39:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/ShZ4LfMthKwsMeEIISlsfBx2r3sR6EftyFXdlq+XYHSwv7+vmXgwAh4PI7UtldBRuP+V X-Received: by 2002:a05:6402:498:: with SMTP id k24mr30914432edv.25.1628516350746; Mon, 09 Aug 2021 06:39:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628516350; cv=none; d=google.com; s=arc-20160816; b=M3zZp96NpZnk0dC/dwfoyOg5Ovq/BEwDE+tO0/vAioEihE3elZJwI/5B0Yoe+y+ijq 2HJtqCrpC3notFUHn7L8QBAtr5IUkFkqbf6o6biM2i3AfKz4CqxFTW91HpgCV95OE0bf IovUxdN0x0Z2gYG2qwat79Z+pA9QX+qFvx+e0UgC5aUXyXFzabOGjHe2wO2fx3Xp4jGc GOzm/3E63lXcD448uSZv1XvHEd14ZhXQ8fJ0xZo2Rqtsg2m9/R7+H0giYyYV3oM8XGUZ RS1yKwHTcqf1qU1ybkAZQat4d7SZLYWeCkJ94yof2uoxe/F+hm6cThNTU4GkJTFMF7Xf 5mrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=G8XyvO3Ablvg7EiqmR8sJudEITFk6TS8djc+yncgCyc=; b=pwob5EPlaafTDFexXY6dhUwpJJjVDp72jHc1+EcGebaIOPxdYiJ7ntpJA67v3ScOR1 /dFHo6tqpESXJ9S7LVnbluLEmu6rqK9aZeSIGDceOmlCVCv34R+2ybEXXJ0+WcixPEzg 6CGx/Gr5ovCOHKKujwNrDYSRNsxmz2tNiV+0u1KwulmVHbWJtnknDXgnCHglWzlOH6V+ SKcE0t/f/0nFHZpgi+Qa7LvIAGUpZjMsZuVCVC5fAlWRNCxoUluq71POHAS0bqskbObK 5erSiHvDYc9DNU7pj6gp20zvWpGRkb7LwpNh1fEeRd/rKGZjKjeUqHb4TpWVKkD5TC9D NjLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si17602366edk.106.2021.08.09.06.38.46; Mon, 09 Aug 2021 06:39:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232697AbhHINfW (ORCPT + 99 others); Mon, 9 Aug 2021 09:35:22 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:13256 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232645AbhHINfW (ORCPT ); Mon, 9 Aug 2021 09:35:22 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Gjxs204Ybz1CTxx; Mon, 9 Aug 2021 21:34:46 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 9 Aug 2021 21:34:58 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 9 Aug 2021 21:34:57 +0800 Subject: Re: [PATCH v3 3/3] kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC To: Marco Elver CC: , , , , , , , , References: <20210809093750.131091-1-wangkefeng.wang@huawei.com> <20210809093750.131091-4-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: <03828e22-9869-7c57-3ad0-f266a435e427@huawei.com> Date: Mon, 9 Aug 2021 21:34:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/9 19:21, Marco Elver wrote: > On Mon, 9 Aug 2021 at 13:10, Kefeng Wang wrote: >> >> On 2021/8/9 17:37, Kefeng Wang wrote: >>> With KASAN_VMALLOC and NEED_PER_CPU_PAGE_FIRST_CHUNK, it crashs, >>> >>> Unable to handle kernel paging request at virtual address ffff7000028f2000 >>> ... >>> swapper pgtable: 64k pages, 48-bit VAs, pgdp=0000000042440000 >>> [ffff7000028f2000] pgd=000000063e7c0003, p4d=000000063e7c0003, pud=000000063e7c0003, pmd=000000063e7b0003, pte=0000000000000000 >>> Internal error: Oops: 96000007 [#1] PREEMPT SMP >>> Modules linked in: >>> CPU: 0 PID: 0 Comm: swapper Not tainted 5.13.0-rc4-00003-gc6e6e28f3f30-dirty #62 >>> Hardware name: linux,dummy-virt (DT) >>> pstate: 200000c5 (nzCv daIF -PAN -UAO -TCO BTYPE=--) >>> pc : kasan_check_range+0x90/0x1a0 >>> lr : memcpy+0x88/0xf4 >>> sp : ffff80001378fe20 >>> ... >>> Call trace: >>> kasan_check_range+0x90/0x1a0 >>> pcpu_page_first_chunk+0x3f0/0x568 >>> setup_per_cpu_areas+0xb8/0x184 >>> start_kernel+0x8c/0x328 >>> >>> The vm area used in vm_area_register_early() has no kasan shadow memory, >>> Let's add a new kasan_populate_early_vm_area_shadow() function to populate >>> the vm area shadow memory to fix the issue. >> Should add Acked-by: Marco Elver [for KASAN parts] , > My Ack is still valid, thanks for noting. Thanks,  Marco ;)