Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     Niklas Cassel <Niklas.Cassel@wdc.com>,
        Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Shaun Tancheff <shaun@tancheff.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>
CC:     Aravind Ramesh <Aravind.Ramesh@wdc.com>,
        Adam Manzanares <a.manzanares@samsung.com>,
        Himanshu Madhani <himanshu.madhani@oracle.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] blk-zoned: allow zone management send operations
 without CAP_SYS_ADMIN
Thread-Topic: [PATCH v4 1/2] blk-zoned: allow zone management send operations
 without CAP_SYS_ADMIN
Thread-Index: AQHXjQQDdEnEDRd9FE+0H1SDMaa+rg==
Date:   Mon, 9 Aug 2021 09:57:43 +0000
Message-ID: <PH0PR04MB74168FFA5B2B108429077E829BF69@PH0PR04MB7416.namprd04.prod.outlook.com>
References: <20210809094855.6226-1-Niklas.Cassel@wdc.com>
 <20210809094855.6226-2-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LJdEK1QY/JDbvhuOm6DCCWC5veGUCWhaP+JpVe/XU47KHmR1T8eDyMG5N8f4?=
 =?us-ascii?Q?3+dy9q04NdvjmlPgxHUvyjE10I52MymvVH1JD+8C/pI21RlYm/nEyXYjCVLu?=
 =?us-ascii?Q?eeV9mtILK+Dm9Yykedtn+GaXHRzRUpRTrd4RuNkOdyrVkhxov6Be5g0t3cZT?=
 =?us-ascii?Q?y8d6c6I1zzRiwOTDE1siXCWdsniDMx1rW0eS2bX1y6Xn9oEMN5LgEiDbUs68?=
 =?us-ascii?Q?Xf2mA4IOAAjRp7G+F2GM2kCu2X0gV5KH8egSjHOf5BTI4dTblLeE1gFqf82V?=
 =?us-ascii?Q?4sVTcFLJ9M1kB6rQYPZX99EroZKc5yK0TigVxt0+b11JO9TGrRj1EbHbgnid?=
 =?us-ascii?Q?15pnSgk6FBzsfXVUcLUE1AuHCLoVv2D5ZIeVqfUisCqVsLcT7umzwqnfkyyG?=
 =?us-ascii?Q?bZpp2YnBo7Dk8tndUUhyFgu+V7uzbkYpHwGwcxJbUzejfnD6DjTsd6Ko54bq?=
 =?us-ascii?Q?BZ1plH8jvEEnoxBPQs0LAR1c7u0rMxqnWJl3N+Fjib7SKi9kkzee23+RBcJG?=
 =?us-ascii?Q?1O7Vsclh78s2pc+NC5R0PCLIauWqd640hWSSIzREOrO47ajV4o+RfMHkQS5o?=
 =?us-ascii?Q?Hk1wBya1Hxoe+1lRyBt1GXxS19MhOcs7HsfZME+D9f1TesLGbcKGVSJqIuCB?=
 =?us-ascii?Q?hqjuHcnP56vqZLGape7F2tO7ZmUCVwSodlZ0M43cHVsTrnpxI1pE1m8A9wLL?=
 =?us-ascii?Q?bUQ09/4pSlUFo9fMCxH/fwfYg3u9P0vP/eFoLn2dJeG21nCWBdaEzsTm98YV?=
 =?us-ascii?Q?5Oy/nthMRJBkiS4TQoT1ToCPT0CP1bnv1stKB9iUYiojKWvEW9JlaYug4S9r?=
 =?us-ascii?Q?YHSfwCVNaL7lfvTESPM74tlCTqUQGe8s/DQiFrD1y5UzkOXuhIPuaWy+uXQr?=
 =?us-ascii?Q?P0fYFtDix/eT6NgebT3ityw3awI/NrGIc9Vz47Q+tdy4L2RRI67HLquq4WCi?=
 =?us-ascii?Q?xNnlyff0FD9DB78Zt5uND/w/i20VokfTyjntpPI3xxWpOaC1BAwtuDay23eF?=
 =?us-ascii?Q?NZpHld6rxGz6h3hLjk9b1RqxX4j9AzS3HhuXWb6AOBtuqn36xHE48lkS+MB9?=
 =?us-ascii?Q?ZmaMUoiu/j1MrCUYqbKp7jQb+T23Vds1wnqUpYfWp4ZLUOyg/ZS6i229wlmt?=
 =?us-ascii?Q?piq06aV5vJjXRcXajw36VkebVM7DpY5gPEihkp11SB0ysDKMyxTAZnvs31+3?=
 =?us-ascii?Q?aYl1gMYAu20a4moEJC/lfNOeCJ9eAbIv7lx99US81QxVSLPk45RHKRIZnKVm?=
 =?us-ascii?Q?Hogc6gz1f7LEao7o6pLncaN4Y1wuX3UxJgSQXGLxNg+mL6kfO1ZhVvcYwmcI?=
 =?us-ascii?Q?Qoc9s0JSS5o+MuwFoEWChN66MCICxp7B7D3fOXYVvWUneklAtqCGpbDfNS5r?=
 =?us-ascii?Q?387PAKAMF3Hd/zWGdnph25gIWXVq0Vs7yjeA4vHQEPrH6tvklw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7416.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9ef5dcf-eeba-47c7-7b37-08d95b1c223b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 09:57:44.0026
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W/2EitU8tgSMcGIOVZZq2W06Noyza0RzvIslWa657B3XCfeeFpu5iLOJR1Eh/pnPcbC0xNaZMTDG1h/n5ZWBq+CvAogfhMF8u2nH96tcWqo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7160
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/08/2021 11:50, Niklas Cassel wrote:=0A=
> From: Niklas Cassel <niklas.cassel@wdc.com>=0A=
> =0A=
> Zone management send operations (BLKRESETZONE, BLKOPENZONE, BLKCLOSEZONE=
=0A=
> and BLKFINISHZONE) should be allowed under the same permissions as write(=
).=0A=
> (write() does not require CAP_SYS_ADMIN).=0A=
> =0A=
> Additionally, other ioctls like BLKSECDISCARD and BLKZEROOUT only check i=
f=0A=
> the fd was successfully opened with FMODE_WRITE.=0A=
> (They do not require CAP_SYS_ADMIN).=0A=
> =0A=
> Currently, zone management send operations require both CAP_SYS_ADMIN=0A=
> and that the fd was successfully opened with FMODE_WRITE.=0A=
> =0A=
> Remove the CAP_SYS_ADMIN requirement, so that zone management send=0A=
> operations match the access control requirement of write(), BLKSECDISCARD=
=0A=
> and BLKZEROOUT.=0A=
> =0A=
> Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")=0A=
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>=0A=
> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
> Reviewed-by: Aravind Ramesh <aravind.ramesh@wdc.com>=0A=
> Reviewed-by: Adam Manzanares <a.manzanares@samsung.com>=0A=
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>=0A=
> Cc: stable@vger.kernel.org # v4.10+=0A=
> ---=0A=
=0A=
Looks good,=0A=
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>=0A=