Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Waiman Long <llong@redhat.com>
Subject: Re: [PATCH] semaphore: Add might_sleep() to down_*() family
To:     Xiaoming Ni <nixiaoming@huawei.com>,
        Waiman Long <llong@redhat.com>, linux-kernel@vger.kernel.org,
        peterz@infradead.org, mingo@redhat.com, will@kernel.org,
        boqun.feng@gmail.com
Cc:     wangle6@huawei.com, xiaoqian9@huawei.com, shaolexi@huawei.com
References: <20210809021215.19991-1-nixiaoming@huawei.com>
 <48cddad4-0388-ae8b-f98b-1629b9ae590a@redhat.com>
 <1a5b0f50-b071-2d1c-5277-b6d7f652c257@huawei.com>
Message-ID: <65fe396a-b10d-2388-8229-05fd43d58927@redhat.com>
Date:   Mon, 9 Aug 2021 08:52:48 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1a5b0f50-b071-2d1c-5277-b6d7f652c257@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 8/8/21 11:51 PM, Xiaoming Ni wrote:
> On 2021/8/9 11:01, Waiman Long wrote:
>>
>> I think it is simpler to just put a "might_sleep()" in 
>> __down_common() which is the function where sleep can actually happen.
>>
>
> If the actual atomic context hibernation occurs, the corresponding 
> alarm log is generated in __schedule_bug().
>     __schedule()
>         --> schedule_debug()
>             --> __schedule_bug()
>
> However, "might_sleep()" indicates the possibility of sleep, so that 
> code writers can identify and fix the problem as soon as possible, but 
> does not trigger atomic context sleep.
>
> Is it better to put "might_sleep()" in each down API entry than 
> __down_common() to help identify potential code problems? 

Putting "might_sleep()" in each down_*() functions mean that whenever we 
add a new API function, we have to remember to add "might_sleep()". If 
we put it in down_common(), it will work for any newly added API 
function in the future even though I doubt we will add any.

Cheers,
Longman