Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 9 Aug 2021 18:23:14 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, fmdefrancesco@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove the dependency on ipx network
 layer
Message-ID: <20210809152314.GT1931@kadam>
References: <20210809141339.2593-1-caihuoqing@baidu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210809141339.2593-1-caihuoqing@baidu.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNXP275CA0032.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:18::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Mon, 9 Aug 2021 15:23:29 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b41624bd-df15-4aa1-e3dc-08d95b49a741
X-MS-TrafficTypeDiagnostic: CO1PR10MB4513:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB451350AE2E9A5013BE56E7C28EF69@CO1PR10MB4513.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: KI0AW7RlV5T3u3Cx+f8zlWT++m7YSjyNsT5ymN10wMqcEG+0VGPZEcsXb7BT+JG2X3Xu3z0FUVV2nXqigkiKaI69dt2EINNfi8nuF6CrP2CR7vumbHHDr1WpVI1KdkvY/+IoFFTI/Nj8sn9aUOZFc2salpRibk0ztGRcgRfBlkWPyLLqxVt43T6vncjLmVOQEDD9jQa1jhNPppuAHdELvu6pml5mjBcaCKlbui6eZ0ACc7KhlY5VQslaP48dYApXX1m0WEUsdbSxS2xTO8GI9dBB/pVO4bA+wS1GUKhxzcw5I7AnHjDF4pnMCItrMl4ex2QvZHoC5T0JB/I0LZ6/GUD2FaY9jNfrx6C99MTgiSqCQTNxPhm3W4qv950SkFz1zknRJL6acS4S1SigPXQFMZCad5IbMFYm9JOtWsCdS+hjhNF1MQzM0YzcQdLXTS8tqgwhhlE+EJq6TObOLUxbjDqClMILCt3/wSV6jJAxAo5IS4WSN8Q8IqpzbSaFPu52iWh66PuzaZ8yXNf+WutYIj8gFMBwnEDQERsNfwD6SQ6BUzyiRHki3H3GVW00KqGt9HnK3OWaq1PWwh2tSM5L/+3syfHcWPzaDe/WJMuJwdLLnMcCQxm+JtZ/QJMgg4ywVaVlmwdx6p8ECPfN0ltdAiaanlOrHvCnVELhrVB6guZu2GG6eHDv0j0NXeDulXilHTp12XAGV9j3Nnm3yIKHYw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(376002)(366004)(346002)(396003)(38350700002)(9576002)(2906002)(1076003)(38100700002)(66476007)(26005)(52116002)(66556008)(66946007)(6496006)(186003)(478600001)(4326008)(5660300002)(316002)(4744005)(8936002)(83380400001)(6666004)(33716001)(8676002)(6916009)(86362001)(55016002)(9686003)(44832011)(33656002)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c7kcahZAE3p8mdzVjqMCGp1xagrY6Ud7OAhfMgLAU6cJvJU2i2iBtAhtzUsd?=
 =?us-ascii?Q?gpf1t3QaCH5p7+sqouGatPxr/QtH2sexpxriBnddGMzB/MhwOx5AGQh8p0vL?=
 =?us-ascii?Q?kzQ4yQSKHqqTYYmK2BrEjjiYPiRqRJl+nE879Zhlg2w5+PJ4n28c+Eu7fpaQ?=
 =?us-ascii?Q?b/solNdAMu7WyN0mS2HcIrSo7NZ9QFXVSvxwCxc7+HQYUQ8tp2eLUs4yQeVF?=
 =?us-ascii?Q?dXmz3czW2hfAXTQAaai46HP74xCWNGRUKxnP+isnPUJXxPWarKUApuvwZoeL?=
 =?us-ascii?Q?P3GL+OwFRljI49tgClShI4CnghqoIHkMT7sC992UVngrlKF0WUfg9gEtWTJd?=
 =?us-ascii?Q?wz73RzZgfY/h5CCCsz+jybdunq0KuJ6+MFXGp9vb6y3S54sdfjIb+zR4VNvk?=
 =?us-ascii?Q?suyykDYrPdFAVf3auT/djKmvrfw/zL6r+39pqZPoQRmqhZkJK8BJUh7wD78F?=
 =?us-ascii?Q?xLwlviPlaBrEDp9l0LqGI8bzVyEegXfh1SNU//5AScjd8XrXQU6WiLPJLtl+?=
 =?us-ascii?Q?JeM8SZWMLg5jpWjR1NYcb+Z4RUXR2xCkNnDgLhuwa4a/8VE29E3OF7/aCflU?=
 =?us-ascii?Q?cB06Oq5esoFGVj7LTbK3psOI3w7XSq6PkGKABNjS4GhUx8/CMTk6UvYOBFon?=
 =?us-ascii?Q?E9vLzNxp/04LQ4lsaP5dxn9Z9Bca7x0GX6iJ4WZo5CrCHZWEH/LKUseQePHg?=
 =?us-ascii?Q?lVW4zqTTEMatjb1L/NYDfAo4Rorx4XKxIeJR0NS3zbTA22ucfzB/ivK/kYs3?=
 =?us-ascii?Q?wtufpBNCxJnESMhHnYlM34gUc4a4XESD5bIYDuFNJs6VSVXjGlDBojvQnkoe?=
 =?us-ascii?Q?BASuFa6A1l3KisLCW1lOPc+vZATx+oekTUz3mOo+AbdMkP48W7+uEr/s8gV/?=
 =?us-ascii?Q?PPnOa7Aeq3a+bzQpBuQSo6c9OisHd8lmlfD4LncmWnSj5t3xfUh/uR9q6E+B?=
 =?us-ascii?Q?O/JykT9wbHh0lI19Hs9d9GN+3wQY7OROgZvXn1dY1++hhTCUXIKu+gkimlXX?=
 =?us-ascii?Q?aAAg2Q6FCzArXk3+p8LG1ESsHJdPddmg24iD+LUQEY8/YmWSOtuHmKGQIdnJ?=
 =?us-ascii?Q?ww82mMIvbEJESGOyQn+dq1Cf+srzB9B5hT3/+1BERxnIeKkoAUN5XJb2ZQvn?=
 =?us-ascii?Q?WSpXzRvJ2eRYBiXSR5RIyth4qIgKuksFGM77+6jdgrU9fWEcYCiA5kIYuqpA?=
 =?us-ascii?Q?jES5vxGTI7d4tByZTKjROvTobYByU2/48evT1pUXpQwQ2l8oFFqKPIfF3Ycs?=
 =?us-ascii?Q?EbcOSVCEBE787IezgbUKDYcA1LVVwZWdKBg+CfbZPY2oAyQheap+vEDobRCT?=
 =?us-ascii?Q?BrS+LbFrNTt7OXiDeLSfKdZg?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b41624bd-df15-4aa1-e3dc-08d95b49a741
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2021 15:23:35.0127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ifOexLVc4pOUMLdzD3Sv28OTi95GNEj67pBL3tynkOVEn6RAvT72CUuU7/C8JEJmAJurglTJWAYSPhhAvmaRJ/eLCzS9c8z9MYTqRWc9NHA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4513
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10071 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxscore=0
 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108090112
X-Proofpoint-ORIG-GUID: 2egPT87N26MzvJazjl0UMMbi-etZCOfD
X-Proofpoint-GUID: 2egPT87N26MzvJazjl0UMMbi-etZCOfD
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 09, 2021 at 10:13:39PM +0800, Cai Huoqing wrote:
> +			if (!memcmp(aarp_snap_id, framePtr, 5)) {
> +				framePtr += 5;	/*  eliminate the SNAP header */
>  
> -						DEBUG_INFO("NAT25: Protocol = IPX (Ethernet SNAP)\n");
> -						ipx = (struct ipxhdr *)framePtr;
> -					} else if (!memcmp(aarp_snap_id, framePtr, 5)) {
> -						framePtr += 5;	/*  eliminate the SNAP header */
> +				ea = (struct elapaarp *)framePtr;
> +			} else if (!memcmp(ddp_snap_id, framePtr, 5)) {
> +				framePtr += 5;	/*  eliminate the SNAP header */

To me this looks like we're still parsing an IPX header but we just
deleted the "ipx" variable and any debug output that mentions IPX.
What?

It doesn't look like nat25_handle_frame() is ever called so once you
delete that then you can delete the whole nat25_db_handle() function as
well.  I'd prefer to see that kind of function which deletes whole
functions and the compiler will complain if we delete something unused.

regards,
dan carpenter