Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp2898617pxt; Mon, 9 Aug 2021 11:25:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/yTxVjwH9zxMkfrd68xNHn6kM/kqGEwh6z5wrYEt0pxw/kS7c3dj4cR8p5EudxLSUr+n1 X-Received: by 2002:a6b:6606:: with SMTP id a6mr369695ioc.69.1628533550631; Mon, 09 Aug 2021 11:25:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628533550; cv=none; d=google.com; s=arc-20160816; b=hvcdPT/v5Ejr3nWwYixpvdhKgdB0Nm1m4zSDGHES1ScMiE/ssImlX8KnDnN7pGiWxx fasqe+YJwmHaOhWoIy2BKXVzrQjY3hfJqXSJah7MQ2+7uoy6v76TNfMVJLTYiDFIuhE1 3CUUSOpA6lGULWb2OJw8G5ZNLo00/lUiPhtzT717WfQAUQIGrMujJMrkKyZMIa3ry+dR 8lpo1XDF4DhtLXJAb8jGfKdqHfsd+bZ0u/DZn4xIFn9Dp4ZlNL20/dRMNPGNvHwYELOc l/eCwud+cBq7NkQjHZDEFoZG+o8aQtK/x5MGI+wqSi5OPRM83BWSv2pX6YiPOxQcaNAS tH6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=tDOfWjGdsyuIyylW8J8O8/FCq1h6g+rfI7buXbmQ0Jg=; b=g1cKrEhevLMoVSxbjWQAaY6MhVFWnFAbAsaX1brbNjR2ILz1wj7ITBvHvLJT8AzbKg BBdC2qI5RPZGsTdg35yNPQ2uC72QDtSyvcopV2QHPP6p9qw2ypwmn0YDZroE9V2uuEo/ ymvp4KniJZwAlR5d4ZdU5h+H3KNdNUvb4/WSOZZVTvgaBNoERXzBPW5bd1wjbRW+Caye erBNZB194BRTjDV3JUt9aiFjKp9k2m2it5VxQfTKoATvOyk3R9dYrPAY/J4FOjS40HI5 mHv2fcHvoP3mJueVIq/IlUu5hnV2nKmggO74XuaDQ4kxnNSa/gVNsGUougOewvs9T3bl 8yyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=sFLArbVG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l8si18325613jap.104.2021.08.09.11.25.39; Mon, 09 Aug 2021 11:25:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=sFLArbVG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232739AbhHISZK (ORCPT + 99 others); Mon, 9 Aug 2021 14:25:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:56390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbhHISZJ (ORCPT ); Mon, 9 Aug 2021 14:25:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 16BF961004; Mon, 9 Aug 2021 18:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1628533489; bh=tDOfWjGdsyuIyylW8J8O8/FCq1h6g+rfI7buXbmQ0Jg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sFLArbVGTyA8p27aYlQGpKtrlV0EUYQTK5d9eFT2P/e8nkcpdB4iWP2zB04li1DAr xYZTpkl2DKt61PYuQuJxZwfvs64rJiMh7mKyC40xfec+ZUPvYbUY4Edzr2MDXwH0X/ YI1L6iPzZ73xXNo/r0HLNl0Cc8K77GWOF4zDdYcE= Date: Mon, 9 Aug 2021 11:24:48 -0700 From: Andrew Morton To: Vasily Averin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@openvz.org Subject: Re: [PATCH] mm: use in_task() in __gfp_pfmemalloc_flags() Message-Id: <20210809112448.3d7d8f2522e18e75ba6e31c0@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Aug 2021 11:23:29 +0300 Vasily Averin wrote: > obsoleted in_interrupt() include task context with disabled BH, > it's better to use in_task() instead. Are these just blind conversions, or have you verified in each case that it is correct to newly take these code paths inside local_bh_disable()? If "yes" then please provide the reasoning in each changelog?