Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210809120050.679048-1-sergio@lony.xyz>
In-Reply-To: <20210809120050.679048-1-sergio@lony.xyz>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 9 Aug 2021 14:37:48 -0400
Message-ID: <CADnq5_NuDDMaKzAm0pRo1dQ-PQ+niibM7u3_1vcAvC4DnP4Ufw@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: Removed unnecessary if statement
To:     =?UTF-8?Q?Sergio_Migu=C3=A9ns_Iglesias?= <lonyelon@gmail.com>
Cc:     "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        xinhui pan <Xinhui.Pan@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        "Kuehling, Felix" <Felix.Kuehling@amd.com>,
        Huang Rui <ray.huang@amd.com>,
        Lee Jones <lee.jones@linaro.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Sergio_Migu=C3=A9ns_Iglesias?= <sergio@lony.xyz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 9, 2021 at 9:59 AM Sergio Migu=C3=A9ns Iglesias
<lonyelon@gmail.com> wrote:
>
> There was an "if" statement that did nothing so it was removed.
>
> Signed-off-by: Sergio Migu=C3=A9ns Iglesias <sergio@lony.xyz>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd=
/amdgpu/amdgpu_fb.c
> index 09b048647523..5eb3869d029e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> @@ -273,9 +273,6 @@ static int amdgpufb_create(struct drm_fb_helper *help=
er,
>         return 0;
>
>  out:
> -       if (abo) {
> -
> -       }
>         if (fb && ret) {
>                 drm_gem_object_put(gobj);
>                 drm_framebuffer_unregister_private(fb);
> --
> 2.32.0
>