Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3062979pxt; Mon, 9 Aug 2021 16:07:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6CyzvhpXWmabWaAXQJh5zLITeviSVE/A4IdDTE99pNBOwxSRl3L/CjxyRETKS2QdvXAzg X-Received: by 2002:a05:6402:95c:: with SMTP id h28mr943533edz.199.1628550455585; Mon, 09 Aug 2021 16:07:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628550455; cv=none; d=google.com; s=arc-20160816; b=UPiaSsNfXZ+RZl/ok2cudgNc7RRj1R/KHxPJraLyGva/K1p04R9+tp5lOk9twyZVfN 82fagnXqlfKqAH3C8WXLqvbKL9fYXJATCO5wDNAQ7or+UOCbxDZIbgD6YRwseBtpQNDB wqPcdIr5nrwdcvfkQ0F7NagBQ2N14iUOBiHB6eVRTV5Kj65SNXw2Aa5skMJaoH+w7wCn 6Oc0mRisaLKG7fNhw8VKAmZCKlai+USWa1vnSF2fg7cToqtf2qqnG2vupcsBwfrbPlAz ySjhLZ9kxKD9/ShFmaJLRjqAyAc6Tan3OHh6GkJIavKBhdVdcrzImrSxt8a0/98Ik9pF xwYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=CfHLR53GxniR3wU02HDhkbAPYLeAvsBtLC9NaIDklro=; b=ZxOLK7ciwcY8KnIdNhpXzT9hbP+ifchCXi8R3mjojUYBPNPpyyfn3tbBukZTj8WdFD xz1KiH/YCD0h/iNAXP7ZbImrmWgYvrcOYKsB/aKgIRDVsQqi6vq2TIZ6QPM4UHYD2X7C TtErbU5uZtlfJZNKEMUlvrbFOBz2ImXkjhWh8EvyIaqxr3LXRu+EONStoNFtxXLbpQZp B+NEfaUeBpecqqbmQ6NqwTi340epcgWY4ez2e7jQ1DjvUulfqQk+67i5uFWuM8ushn5P k1+5T3mWa6PIMsaDsLGCKaTq4Qzsw/C+ynHexHAAXLpAFknLm9WcFd0taAl8EmPhvjPo Zskw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Le3Wg2uS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si14480633edc.333.2021.08.09.16.07.11; Mon, 09 Aug 2021 16:07:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Le3Wg2uS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236342AbhHIUx4 (ORCPT + 99 others); Mon, 9 Aug 2021 16:53:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:43218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234454AbhHIUx4 (ORCPT ); Mon, 9 Aug 2021 16:53:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 13A0961019; Mon, 9 Aug 2021 20:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628542415; bh=VxjNPYWZUiQJduiJINk5u08LoDlzM1BFYtxKoZ0PqjE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Le3Wg2uSqGKjxozUllFPAR1ZeOOpaHLAwVQlCmBSdTkf+E2jAgiw+otWdZTVQFvWi mlJ/el8KlkKThkDJIbpFKajmf3TjfLeDZ6iKpt7wRX9WZkPHBRHdfBoM8odaT9B4hl zYJNbLsZQ9ea3F7n08WoQ6xKUUnwe9ZXhaKG+yMk93Ax4Jz7aAALoy0PZk7hqOEMxJ /3j3mxW0xKfgFJHXdgkwI3A19eifzSCZiZhLkCsB4j9YpbV6D/9R8JUi4ot35BilmW 9I0BdNR6QvMR4fb8hSe9QzoP4BfrVHHBB0J2OMNw4+uMXsGCLm7VyeHZneH15UqIIz l4kqKLj/h7ifA== Date: Mon, 9 Aug 2021 13:53:34 -0700 From: Jakub Kicinski To: Rocco Yue Cc: "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Matthias Brugger , , , , , , , Subject: Re: [PATCH net-next v3] ipv6: add IFLA_INET6_RA_MTU to expose mtu value in the RA message Message-ID: <20210809135334.79f000e2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210809140109.32595-1-rocco.yue@mediatek.com> References: <20210809140109.32595-1-rocco.yue@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Aug 2021 22:01:09 +0800 Rocco Yue wrote: > +static inline size_t inet6_iframtu_msgsize(void) > +{ > + return NLMSG_ALIGN(sizeof(struct ifinfomsg)) > + + nla_total_size(IFNAMSIZ) /* IFLA_IFNAME */ > + + nla_total_size(4); /* IFLA_INET6_RA_MTU */ > +} Please don't use 'static inline' in C sources, static is enough