Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3103516pxt; Mon, 9 Aug 2021 17:13:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNHIiwU3ttdF4bQI0QCfT1Yej36aafZwyX2D7xGdZ/qUzf3gG42WyGPk32n7+0aJn+xTKE X-Received: by 2002:a17:906:ecb3:: with SMTP id qh19mr3925733ejb.413.1628554410527; Mon, 09 Aug 2021 17:13:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628554410; cv=none; d=google.com; s=arc-20160816; b=vq4De9iOdWP7Y8O+WFDMOiY42t/eKbU/qTdnWWkRFHBN4Yp/H6XQCkACwytmzXke15 B7ZGtwOowc8yIGbAHhzmPWBmvnc6Pcn/fkX9fDtF+JEeog9+YIx0rYI5fHxfrkT1e8VN ZDcioNOOJVVivrI8JGKnmyeK/0AFd24Njf11aTh442/o3nuhWVHElp1GNyjd6qujIfA0 w4Vw3t6shBeSZUBkLq5fkGEBkD6M5bjkLcqm9DG9VndzxyxpBLdrV4BQ52sKoVQSWLcC 8xYM/eNHPL9RkbK+TtqVc57GxiexGAvCufvfSw0gvs011pREBwucbRRF9UDNILmBJ/Ej pBgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4cC8cORMfMsOUvKwue2jm+l+G8ynAhP1fL8ZsXQ5bos=; b=B+jUmx3k2sg1eYy7PXIG0w35bv9LV9WyvFZPaIzDAbYGKIVorIWPW36/vO49o7zqsF tg+LpqP7fIxMh1Ml36Ht5GGRggygTVTS3dvGAtAhIv5QoTSqu/V3twkrqfu1pwWnOJ1s P6a4rySGzuWBtMEYJkdRnsq6elNnAAYmo8foWXz1EZCyxsL+FvimBtYoHRIEbwIzf/fl MnUjwEdDYf+ORrxyjp2977n0FPthYMs4TrE8vcd04qoslfM8kAgwQPmhZXs16+Ac3gup naLbZE+f2eFuaNeVSYUOh1fj3li4AFFLYnsRaQy1GKNFr0Gr+1pXjVhiD4R++yifiUtx 0VyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mO9bSUQU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a25si5945441edj.71.2021.08.09.17.13.06; Mon, 09 Aug 2021 17:13:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mO9bSUQU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236351AbhHIUzT (ORCPT + 99 others); Mon, 9 Aug 2021 16:55:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:43476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234454AbhHIUzS (ORCPT ); Mon, 9 Aug 2021 16:55:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 60A2561019; Mon, 9 Aug 2021 20:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628542497; bh=OtefdCSZIvmHhVrzmgv2TAsBD5y3mG5YUCqrPRJO/Cg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mO9bSUQUAd3FiiCZ/KIEK3SjebiwUOOCorMcAHbfb2UERa48G5cRMVEsuWF7RMNSv tkNrnx4FdnfJDN9p6lr6dHP/LDg0/cku9b8YC6srUU0RAaLMI9LbH9RSB1/v8cm8iZ HnkSwvpPeYIrd1e4qogBjYIc0iOaZQGYjx41tlUXCSvPaL5KI/7ZNSEJBQ2eZEGcMW AGpapmhwMLaVzGPXRVdnn2IO+vsRNMg16TwRannSqiBEhrt6FDUfuoNcDQmIwqg8U4 yCWJrkV6eBtsD2DtH3jp1AS70ppVEzuQbAr/vsq1nGsuV5d7rE+ty6gKFpnP0N/hIR uK9QfiRhv/m0g== Date: Mon, 9 Aug 2021 13:54:56 -0700 From: Jakub Kicinski To: Guangbin Huang Cc: , , , Subject: Re: [PATCH net-next 4/4] net: hns3: add support ethtool extended link state Message-ID: <20210809135456.397129f5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1628520642-30839-5-git-send-email-huangguangbin2@huawei.com> References: <1628520642-30839-1-git-send-email-huangguangbin2@huawei.com> <1628520642-30839-5-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Aug 2021 22:50:42 +0800 Guangbin Huang wrote: > + if (!h->ae_algo->ops->get_link_diagnosis_info) > + return -EOPNOTSUP; Missing a P at the end here, this patch does not build.