Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     a.zummo@towertech.it, Cassio Neri <cassio.neri@gmail.com>
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v5] rtc: Improve performance of rtc_time64_to_tm(). Add tests.
Date:   Tue, 10 Aug 2021 00:10:00 +0200
Message-Id: <162854698133.238383.3736740084127309703.b4-ty@bootlin.com>
In-Reply-To: <20210624201343.85441-1-cassio.neri@gmail.com>
References: <20210624201343.85441-1-cassio.neri@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 24 Jun 2021 21:13:43 +0100, Cassio Neri wrote:
> The current implementation of rtc_time64_to_tm() contains unnecessary
> loops, branches and look-up tables. The new one uses an arithmetic-based
> algorithm appeared in [1] and is approximately 4.3 times faster (YMMV).
> 
> The drawback is that the new code isn't intuitive and contains many 'magic
> numbers' (not unusual for this type of algorithm). However, [1] justifies
> all those numbers and, given this function's history, the code is unlikely
> to need much maintenance, if any at all.
> 
> [...]

Applied, thanks!

[1/1] rtc: Improve performance of rtc_time64_to_tm(). Add tests.
      commit: 1d1bb12a8b1805ddeef9793ebeb920179fb0fa38

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>