Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] netlink: NL_SET_ERR_MSG - remove local static array
To:     Joe Perches <joe@perches.com>, netdev <netdev@vger.kernel.org>
Cc:     Johannes Berg <johannes.berg@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <1f99c69f4e640accaf7459065e6625e73ec0f8d4.camel@perches.com>
From:   Jonathan Toppins <jtoppins@redhat.com>
Message-ID: <c32a4a3c-c7df-cb8d-ecb4-7c1738cfd15c@redhat.com>
Date:   Mon, 9 Aug 2021 18:30:33 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <1f99c69f4e640accaf7459065e6625e73ec0f8d4.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/9/21 1:04 PM, Joe Perches wrote:
> The want was to have some separate object section for netlink messages
> so all netlink messages could be specifically listed by some tool but
> the effect is duplicating static const char arrays in the object code.
> 
> It seems unused presently so change the macro to avoid the local static
> declarations until such time as these actually are wanted and used.
> 
> This reduces object size ~8KB in an x86-64 defconfig without modules.
> 
> $ size vmlinux.o*
>     text	   data	    bss	    dec	    hex	filename
> 20110471	3460344	 741760	24312575	172faff	vmlinux.o.new
> 20119444	3460344	 741760	24321548	1731e0c	vmlinux.o.old
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Seems reasonable.

Acked-by: Jonathan Toppins <jtoppins@redhat.com>