Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v6 1/2] PM / Domains: Add support for 'required-opps' to
 set default perf state
From:   Dmitry Osipenko <digetx@gmail.com>
To:     Rajendra Nayak <rnayak@codeaurora.org>, ulf.hansson@linaro.org,
        bjorn.andersson@linaro.org, viresh.kumar@linaro.org
Cc:     linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        swboyd@chromium.org, rojay@codeaurora.org, stephan@gerhold.net
References: <1628074696-7979-1-git-send-email-rnayak@codeaurora.org>
 <1628074696-7979-2-git-send-email-rnayak@codeaurora.org>
 <f58e631d-67a7-4981-ce59-6a4772b44564@gmail.com>
 <c43ddc6b-32ca-433d-76f2-901cb594eaf1@gmail.com>
Message-ID: <9588f01d-1cb6-7ca3-eb41-74259f1678f6@gmail.com>
Date:   Tue, 10 Aug 2021 02:46:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <c43ddc6b-32ca-433d-76f2-901cb594eaf1@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

10.08.2021 01:44, Dmitry Osipenko пишет:
> 10.08.2021 01:26, Dmitry Osipenko пишет:
>> 04.08.2021 13:58, Rajendra Nayak пишет:
>>> @@ -2637,6 +2643,8 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
>>>  {
>>>  	struct of_phandle_args pd_args;
>>>  	struct generic_pm_domain *pd;
>>> +	struct device_node *np;
>>> +	int pstate;
>>>  	int ret;
>>>  
>>>  	ret = of_parse_phandle_with_args(dev->of_node, "power-domains",
>>> @@ -2675,10 +2683,26 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
>>>  		genpd_unlock(pd);
>>>  	}
>>>  
>>> -	if (ret)
>>> +	if (ret) {
>>>  		genpd_remove_device(pd, dev);
>>> +		return -EPROBE_DEFER;
>>> +	}
>>> +
>>> +	/* Set the default performance state */
>>> +	np = dev->of_node;
>>> +	if (of_parse_phandle(np, "required-opps", index)) {

The OF node returned by of_parse_phandle() must be put.

>>> +		pstate = of_get_required_opp_performance_state(np, index);

If you have more than one power domain, then this will override the
pstate which was set for a previous domain. This code doesn't feel solid
to me, at least a clarifying comment is needed about how it's supposed
to work.

>>> +		if (pstate < 0) {
>>> +			ret = pstate;
>>> +			dev_err(dev, "failed to set required performance state for power-domain %s: %d\n",
>>> +				pd->name, ret);
>>> +		} else {
>>> +			dev_pm_genpd_set_performance_state(dev, pstate);
> 
> Where is error handling?
> 
>>> +			dev_gpd_data(dev)->default_pstate = pstate;
>>> +		}
>>> +	}
>>
>> Why performance state is set after genpd_power_on()?

Should set_performance_state() be invoked when power_on=false?

I assume it should be:

if (power_on) {
	dev_pm_genpd_set_performance_state(dev, pstate);
	dev_gpd_data(dev)->default_pstate = pstate;
} else {
	dev_gpd_data(dev)->rpm_pstate = pstate;
}