Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3257042pxt; Mon, 9 Aug 2021 22:17:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiHkIMHdE8Tz2GGiGKASlCVUVusgC0jZ/6S/Hv59H5/lAWS3ujLPzmmC8lhbaYUHFvD98M X-Received: by 2002:a02:a390:: with SMTP id y16mr26428539jak.120.1628572636593; Mon, 09 Aug 2021 22:17:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628572636; cv=none; d=google.com; s=arc-20160816; b=ivDqkVaouAhEErIQrnO3ifusnjarMt2jHNSJsTva5tfvRYGiN2c2Hy2B9KxWgFt4n7 jcBwtoS+6ZKlX05Tgp9NZvmqmaUXDNbVQ95qMr1FcJ2KOa23XKkkHPrX9XXDfbcwMs5N /BKlEVkKkZ10K9rUIDc/FQ621FOawf2sDac3m4kkbZU7Izk1DGvSI8is+wvzh5rcEJPH l9Q8khnwpHTWws1bLXh2BSU2MHZ3BTeu6hIslxpL9FmR6H12D2cEnU1OlLU946FiugmS gI/UkLhk9SULcgBCskDer8J4rgoy2cg0UfG/WC3RBQeJo5DF0eIFyqYBSTgKWf1fHi1/ DStg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=fBuQJXWuDjUW9s8E9FrF8iJB4RaI+PiisX5kUxOnZQA=; b=IrleDp0Le0wyW7eOHsZa1Mw6ZpC6k1uaGwoVwezdXgQHERweEaZJ/869Tofd3+geoJ q90WBexd5d7UzrBz+yfxdWcz8R/rDTsbc0y13sR6sHBJck6xE35JgKDTMPhx9Icq8XGr y65pO+qWEQRyJ1OkiAU2565cqky26lrEoiPwevvRmQUcsYTb/CSNUVLIt6wSY4eSvWdV rPNunMHCI+sE/8J8L/BJpGmH5nGMO44fKDFEtx+caHjoRbITg/NuTaLhFzkvQ9v31117 Y7yFIqXn3E1WY5p9hwBT6//e5+MrKs2Cuyn0DNjs5UVl+DS8/ulkuEttpI94UxZ415Wx OFsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si22663267ilv.84.2021.08.09.22.17.03; Mon, 09 Aug 2021 22:17:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237174AbhHJBJT (ORCPT + 99 others); Mon, 9 Aug 2021 21:09:19 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:8385 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233980AbhHJBJT (ORCPT ); Mon, 9 Aug 2021 21:09:19 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GkF9S4TYMz85nH; Tue, 10 Aug 2021 09:05:00 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 10 Aug 2021 09:08:56 +0800 Received: from [10.67.102.67] (10.67.102.67) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 10 Aug 2021 09:08:56 +0800 Subject: Re: [PATCH net-next 4/4] net: hns3: add support ethtool extended link state To: Jakub Kicinski CC: , , , References: <1628520642-30839-1-git-send-email-huangguangbin2@huawei.com> <1628520642-30839-5-git-send-email-huangguangbin2@huawei.com> <20210809135456.397129f5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: "huangguangbin (A)" Message-ID: <15810974-d1da-2a43-7a69-45dffff653a2@huawei.com> Date: Tue, 10 Aug 2021 09:08:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210809135456.397129f5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.67] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/10 4:54, Jakub Kicinski wrote: > On Mon, 9 Aug 2021 22:50:42 +0800 Guangbin Huang wrote: >> + if (!h->ae_algo->ops->get_link_diagnosis_info) >> + return -EOPNOTSUP; > > Missing a P at the end here, this patch does not build. > . > I am very sorry, I will modify this fault and pay attentiaon to it later.