Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210806103423.3341285-1-stevensd@google.com> <20210806103423.3341285-4-stevensd@google.com>
 <PH0PR11MB48241565DC7BF06AD01301D3CDF79@PH0PR11MB4824.namprd11.prod.outlook.com>
In-Reply-To: <PH0PR11MB48241565DC7BF06AD01301D3CDF79@PH0PR11MB4824.namprd11.prod.outlook.com>
From:   David Stevens <stevensd@chromium.org>
Date:   Tue, 10 Aug 2021 10:41:08 +0900
Message-ID: <CAD=HUj57PENg8-nbp6oR_+Kxqzkp7rZhXi_JBJ8+_v3w4L=4Hw@mail.gmail.com>
Subject: Re: [PATCH v2 3/9] dma-iommu: bounce buffers for untrusted devices
To:     "Mi, Dapeng1" <dapeng1.mi@intel.com>
Cc:     Robin Murphy <robin.murphy@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        Will Deacon <will@kernel.org>, Christoph Hellwig <hch@lst.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Aug 10, 2021 at 10:19 AM Mi, Dapeng1 <dapeng1.mi@intel.com> wrote:
>
> Hi David,
>
> I like this patch set and this is crucial for reducing the significant vI=
OMMU performance. It looks you totally rewrite the IOMMU mapping/unmapping =
part and use the dynamically allocated memory from buddy system as bounce b=
uffer instead of using the legacy SWIOTLB bounce buffer. As I know, some le=
gacy devices' DMA could not access the memory larger than 32-bit memory spa=
ce and the dynamically allocated memory address could exceed the 32-bit mem=
ory space. Is it a problem?

My understanding is that when devices with that sort of limitation sit
behind an IOMMU, the IOVA is what matters, not the physical address.
The bounce bounce buffers use the same limits for IOVA allocation as
the regular dma-iommu path, so compatible IOVAs will be allocated for
the bounce buffers.

-David

> Thx,
> Dapeng Mi