Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3273638pxt; Mon, 9 Aug 2021 22:52:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5y2GDAFjfdijQI7UQC3CyU6SzPd1LBufSrWXBbF4LtxSAVqUjPe2lyTSjXCFRQRN245QW X-Received: by 2002:a05:6402:718:: with SMTP id w24mr2813824edx.49.1628574724186; Mon, 09 Aug 2021 22:52:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628574724; cv=none; d=google.com; s=arc-20160816; b=M1hGTq4GqHg/1ZnUKonu2ueOfO4UzBw9L9EwwvtoDCWz7xSxcXtCqxqPrI66M1JrvD d36F1ou+KQ+LWLOD3/eoENSAsb94Z9jzMFHgf8V0uERIVUHTzkWNzkP9KQgN4Lnb9iSN 9FmWwxj59pIih9zfC6QxVBhq57Vd5sGTsh4EJK+jgMyJQE4d3+0SYLCPzUp5U/dpBCZ3 jYH9dLVcf9Y9ZEYbHavX7Exy8+71duIqVPt+qO0Bldrq6PLfUCBjhrSEQNtNuIJxXeSZ k2uqZZdal+HK1KZBA6RwhYrLHJsCx7TFTdkB+wo/rAu2TkmK4wBL/19cFBn+ntrGE+Ao zjdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=4obz9WkqAEaS3SU/Ft8ZVbZx29A5UvHIZHpNuPkmvSk=; b=K/ejVQbBKiliwqVA1ZzHDTVlMqmFc6ACVyRB8fyFJGwt34eyC3zqbDfZTpOhPJfD+L ql8f4fW3sOX8T4vf+eSWgH1t0CzxXBqlRlT8J9KTiCd4OaeiqzQorSshV3ntMV1ez6K5 tshbZVodKun76LG+0FPz3DUunmkowcufdQ6MBrqUNEWS0c/b7GL33MwBHfxuJUEpmFnq taQanrcfelfOPljiDMJ3UFReZ0Xrbt0Se04XpHF/NVug0QLKhrtx7E95zxMm+iTmO/qs vGNms1bYD/TJB+URPpQH7+As4Ji3XJuK52BpN9h4uIe1DrYZTzuF+1KwiNpSwFVgpcZI jxVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="kZGou/+a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qo8si8513941ejb.637.2021.08.09.22.51.41; Mon, 09 Aug 2021 22:52:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="kZGou/+a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231716AbhHJCFz (ORCPT + 99 others); Mon, 9 Aug 2021 22:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237315AbhHJCFy (ORCPT ); Mon, 9 Aug 2021 22:05:54 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50EDAC061798 for ; Mon, 9 Aug 2021 19:05:33 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id gz13-20020a17090b0ecdb0290178c0e0ce8bso1560745pjb.1 for ; Mon, 09 Aug 2021 19:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4obz9WkqAEaS3SU/Ft8ZVbZx29A5UvHIZHpNuPkmvSk=; b=kZGou/+ar6VkGad2l0SxaqeFt1SKZRIzP9scQKzNs4UWQkTcp9RFq2j7DzVxV5KgyK 5TlRRQZiF84syxutswoRu9al2wgA6RIdYNPOBxcnTDzmobwr5KimozZFSDPrq4diHXeX ipKAui0LFbQLJxIpk5KS/wFGdunbQWFii1rXT4wS1I8XQZsesNjv4HPv3iAD3ea+upBS JSg6AlDBdu61OSsdQuXUhveKPb1AmEK5XcKA36O+/DwyPCvucbwUCa4b3wIe+ypj3GQo a62adTZ9xmyyPOvuM6rVkvObTb2FdTjAK6ijP2kom0N55yhlEBTjNlqSbSS+QSc+1saE 805Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4obz9WkqAEaS3SU/Ft8ZVbZx29A5UvHIZHpNuPkmvSk=; b=le088yptw6OpQe+QUUz50b30Q69d1MAtP5jYoCpAjQS379w52ffQM1NEY7UacGw1wn oVnxKdJkX+lnlbBKGs2vw0biHl9Us5QgF6WnQYyDsPAbDd2Xer3Tq5BXTW/jUDIwos1h kMr1bI3wuybMKhWoWV2wS78a7Xp7VedU0sfjf277evEsOrzyw7a5gyJjRvsIebHojYlR YTnj4VNFBunPI3YOGfP6JQ3K5ejAqwv1EIM9z4nOVaQjL8AapmVMkOamZN+xdgLH31sW fDHEIieONPWWUgl6mzcdeQ2QdZKS1ByHjPmVW+Wig+4q44fJ6mmx+FDpaTDrr+G+x7ev a1MA== X-Gm-Message-State: AOAM530abc4mLSALzzEmRYpPxJHC6JmT6uCIU9Hadb38fs28px3ErwEu KLY3/DKM9+MX+aOVd5/kD+7+hAYCDckgXHDN X-Received: by 2002:a17:90b:17c3:: with SMTP id me3mr2143130pjb.203.1628561132632; Mon, 09 Aug 2021 19:05:32 -0700 (PDT) Received: from [192.168.1.116] ([198.8.77.61]) by smtp.gmail.com with ESMTPSA id u3sm18289827pfn.76.2021.08.09.19.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 19:05:32 -0700 (PDT) Subject: Re: [PATCH] xen-blkfront: Remove redundant assignment to variable err To: Colin King , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210806110601.11386-1-colin.king@canonical.com> From: Jens Axboe Message-ID: Date: Mon, 9 Aug 2021 20:05:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210806110601.11386-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/6/21 5:06 AM, Colin King wrote: > From: Colin Ian King > > The variable err is being assigned a value that is never read, the > assignment is redundant and can be removed. Added for 5.15, thanks. -- Jens Axboe