Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   QiuXi <qiuxi1@huawei.com>
To:     <viro@zeniv.linux.org.uk>, <akpm@linux-foundation.org>,
        <jannh@google.com>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <gregkh@linuxfoundation.org>, <xiekunxun@huawei.com>,
        <young.liuyang@huawei.com>
Subject: [PATCH 1/1] coredump: fix memleak in dump_vma_snapshot()
Date:   Tue, 10 Aug 2021 10:04:41 +0800
Message-ID: <20210810020441.62806-1-qiuxi1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

dump_vma_snapshot() allocs memory for *vma_meta, when dump_vma_snapshot()
returns -EFAULT, the memory will be leaked, so we free it correctly.

Fixes: a07279c9a8cd7 ("binfmt_elf, binfmt_elf_fdpic: use a VMA list snapshot")
Cc: stable@vger.kernel.org # v5.10
Signed-off-by: QiuXi <qiuxi1@huawei.com>
---
 fs/coredump.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index 07afb5ddb1c4..19fe5312c10f 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -1127,8 +1127,10 @@ int dump_vma_snapshot(struct coredump_params *cprm, int *vma_count,
 
 	mmap_write_unlock(mm);
 
-	if (WARN_ON(i != *vma_count))
+	if (WARN_ON(i != *vma_count)) {
+		kvfree(*vma_meta);
 		return -EFAULT;
+	}
 
 	*vma_data_size_ptr = vma_data_size;
 	return 0;
-- 
2.12.3