Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Leo Li <leoyang.li@nxp.com>
To:     "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Kettenis <mark.kettenis@xs4all.nl>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of
 LX2160A UART
Thread-Topic: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of
 LX2160A UART
Thread-Index: AQHXYejVx8YR0SiBXEyplsaWZ0dlkatsHV6QgAAsv4CAACNCUA==
Date:   Tue, 10 Aug 2021 03:38:26 +0000
Message-ID: <AS8PR04MB8946913A8B97C18240ADBAEA8FF79@AS8PR04MB8946.eurprd04.prod.outlook.com>
References: <20210615131605.616-1-thunder.leizhen@huawei.com>
 <20210615131605.616-2-thunder.leizhen@huawei.com>
 <AS8PR04MB8946D0EB15D631346F4D13198FF69@AS8PR04MB8946.eurprd04.prod.outlook.com>
 <03d7c7be-2f19-9fdf-2a4e-f49a62bb82f6@huawei.com>
In-Reply-To: <03d7c7be-2f19-9fdf-2a4e-f49a62bb82f6@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SUlLmPFdqhoPKBC/eGQ79qtrMAtBUNmEBQ9xyxB4ZbkKxQyIH+nc7meIrb3T?=
 =?us-ascii?Q?O2QLOGROIxLk2jKGLT7JBRnIoa8Nb3NfdGixprCraAEJ7kJJILwL83/qkOPn?=
 =?us-ascii?Q?u/cGMpNvNF/69xH5r+TeLhZPPMAETa5LnV0uFrUGtq+QSXNUGhyefgKEDLlr?=
 =?us-ascii?Q?X34CpB7PREZUbyDXKzmMoh1S1Ct6B4QOcOWaO1XyM/s3dh+kxbHC57GuxCFu?=
 =?us-ascii?Q?zFIz8DTmGwkYan7Kciif+yWqf1ym23CMwRuPveJeSu7A3ix1dAQQ/1gJt6T3?=
 =?us-ascii?Q?HsaasfZqIWEwUcxEaczDNTm1qUCf3RAG6GD1A0diI+D3vKV03DUMYo1CEvgo?=
 =?us-ascii?Q?rSnKmWdMbjbULiVVTyKvY8SaXV4pZrAuHv9ENua4a+fD1IJ3aSq8HslI5E4m?=
 =?us-ascii?Q?65pX6oGzQp4EEWGr5q19JnLixJFyodH2M3dnNkogiHaeuoI9NdjKCRKRhUF1?=
 =?us-ascii?Q?Jn9LmII7eUSUigVDGO4hvLnNHW2O7N0ATBUVSvvO3++571c9HCqMl/pJ++ns?=
 =?us-ascii?Q?eRTy6NbA38I1HW7NF5vZFNyqbLbgXZZCmgEsuzmLlpVj/FjPTTUfvxMGKkuI?=
 =?us-ascii?Q?SrHsb7+hOpgNNHXvmVqnfufarLEc94+2XEohaW0k9IXAmU7himHzy/BzEqV8?=
 =?us-ascii?Q?TQxTwBD3Dar52+Do7Y94WJPzQPXGhFNY1kvTgv7lGvSM0lVHznPsRANHFeQC?=
 =?us-ascii?Q?+pdhTASBur6Ab+JSQajAFkBryNhyP4SrD3jsEYstl9fdgH6Qres/xbXXTEX9?=
 =?us-ascii?Q?kZOEWoeZVN4SqJT/l7Hnbk2NQyxfN7ZQZcG89Rl45YmrFpUiXpevQfspT2kN?=
 =?us-ascii?Q?tvvFVj6CaZHgNjEDPyP3T1EBPBaj1SRettozwxuztS2Ct7hQo3Jg3N48t541?=
 =?us-ascii?Q?syi4qHo2wAmGh4AVKImtD5pPNit5C4donTR5/FKWeskFg6PtaJBD8p6/xiTc?=
 =?us-ascii?Q?02Rx9uxoCJY3shBbvQ0Zc55MN3grN9XBqz8M6JblqXj8OBpVpH1fny0i7HPW?=
 =?us-ascii?Q?owi7sDAwdU9QIU5MUDQJzIBSjN3NY1hGxkZgE5Z4U3sSWOdi40arwy9U0Zd9?=
 =?us-ascii?Q?E8vue08Xu2/u84WWmQfrQzBRrck4u0OA9hnVk3/BV5qK4aTyjq5zJwPhgbtR?=
 =?us-ascii?Q?mGsUz/BqehebVYTYjANob+Ud8iLcapC2ym4K//rYcK6+MhKmiC26dgu970BF?=
 =?us-ascii?Q?ZBqsHqsAMO1HhGBP4iXcRmqa6GcH8vvpt89xwaVnorZUuq93EMSHE7GQF0M7?=
 =?us-ascii?Q?7VNcu5Ee4Y7CsT1OXvGAVyavxTa4M3jKzh84LmoqvLNyyIkZdSDYLu/5DwtS?=
 =?us-ascii?Q?ehTgF6T0YlPyRVvgMCJbjKc4?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8946.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f05fb863-7610-45bb-1e62-08d95bb04fe0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2021 03:38:26.1079
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YtRU2XyxZUu1xpIVuh3ZBkHYuHk981Uk7CvTyDS+WTLctczoFU9LkxY85HgwToMVTlPio1Ti2F0PIQlGaucD7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8705
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Leizhen (ThunderTown) <thunder.leizhen@huawei.com>
> Sent: Monday, August 9, 2021 8:28 PM
> To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>; Rob
> Herring <robh+dt@kernel.org>; Mark Kettenis <mark.kettenis@xs4all.nl>;
> devicetree <devicetree@vger.kernel.org>; linux-arm-kernel <linux-arm-
> kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible strin=
g of
> LX2160A UART
>=20
>=20
>=20
> On 2021/8/10 6:52, Leo Li wrote:
> >
> >
> >> -----Original Message-----
> >> From: Zhen Lei <thunder.leizhen@huawei.com>
> >> Sent: Tuesday, June 15, 2021 8:16 AM
> >> To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>;
> Rob
> >> Herring <robh+dt@kernel.org>; Mark Kettenis
> >> <mark.kettenis@xs4all.nl>; devicetree <devicetree@vger.kernel.org>;
> >> linux-arm-kernel <linux-arm- kernel@lists.infradead.org>;
> >> linux-kernel <linux-kernel@vger.kernel.org>
> >> Cc: Zhen Lei <thunder.leizhen@huawei.com>
> >> Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible
> >> string of LX2160A UART
> >>
> >> Mark Kettenis told us that:
> >> According to the NXP documentation, the LX2160A has a real PL011 UART.
> >>
> >> Therefore, rewrite it to the compatible string of pl011. The property
> >> "current- speed" specific to "arm,sbsa-uart" is also deleted.
> >
> > Sorry that I missed the discussion on the v1.  But looks like this chan=
ge
> breaks the LX2160 boot.  The AMBA matching doesn't seem to work.  And
> the console is not registered correctly.
>=20
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flore.=
k
> ernel.org%2Flinux-arm-kernel%2Fcba3a29f-92b5-072a-9a27-
> 60240f072dad%40huawei.com%2F&amp;data=3D04%7C01%7Cleoyang.li%40nx
> p.com%7C9986b52f71724d7f6ae108d95b9e1d9b%7C686ea1d3bc2b4c6fa92cd
> 99c5c301635%7C0%7C0%7C637641556923909225%7CUnknown%7CTWFpbGZ
> sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M
> n0%3D%7C1000&amp;sdata=3DwReesSfMj1hV2iPTN0%2F%2B%2Fb%2BKJH8xF
> LLcDgOMfjx731I%3D&amp;reserved=3D0
>=20
> Maybe we should fall back to v1.

I didn't look into the problem in detail.  Probably it is because of lackin=
g the clock properties needed by the AMBA bus?

>=20
> >
> > [    0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c000=
0
> > [    0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d000=
0
> >
> >>
> >> Suggested-by: Shawn Guo <shawnguo@kernel.org>
> >> Suggested-by: Mark Kettenis <mark.kettenis@xs4all.nl>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >> ---
> >>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++--------
> >>  1 file changed, 4 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >> index c4b1a59ba424..d2e6f7285674 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >> @@ -920,34 +920,30 @@ QORIQ_CLK_PLL_DIV(8)>,
> >>  		};
> >>
> >>  		uart0: serial@21c0000 {
> >> -			compatible =3D "arm,sbsa-uart","arm,pl011";
> >> +			compatible =3D "arm,pl011", "arm,primecell";
> >>  			reg =3D <0x0 0x21c0000 0x0 0x1000>;
> >>  			interrupts =3D <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> >> -			current-speed =3D <115200>;
> >>  			status =3D "disabled";
> >>  		};
> >>
> >>  		uart1: serial@21d0000 {
> >> -			compatible =3D "arm,sbsa-uart","arm,pl011";
> >> +			compatible =3D "arm,pl011", "arm,primecell";
> >>  			reg =3D <0x0 0x21d0000 0x0 0x1000>;
> >>  			interrupts =3D <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> >> -			current-speed =3D <115200>;
> >>  			status =3D "disabled";
> >>  		};
> >>
> >>  		uart2: serial@21e0000 {
> >> -			compatible =3D "arm,sbsa-uart","arm,pl011";
> >> +			compatible =3D "arm,pl011", "arm,primecell";
> >>  			reg =3D <0x0 0x21e0000 0x0 0x1000>;
> >>  			interrupts =3D <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
> >> -			current-speed =3D <115200>;
> >>  			status =3D "disabled";
> >>  		};
> >>
> >>  		uart3: serial@21f0000 {
> >> -			compatible =3D "arm,sbsa-uart","arm,pl011";
> >> +			compatible =3D "arm,pl011", "arm,primecell";
> >>  			reg =3D <0x0 0x21f0000 0x0 0x1000>;
> >>  			interrupts =3D <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> >> -			current-speed =3D <115200>;
> >>  			status =3D "disabled";
> >>  		};
> >>
> >> --
> >> 2.25.1
> >>
> >
> > .
> >