Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Vadym Kochan <vkochan@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Julian Wiedmann <jwi@linux.ibm.com>,
        Karsten Graul <kgraul@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Jianbo Liu <jianbol@nvidia.com>,
        Vlad Buslov <vladbu@nvidia.com>,
        Bjarni Jonasson <bjarni.jonasson@microchip.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tobias Waldekranz <tobias@waldekranz.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net] net: switchdev: zero-initialize struct
 switchdev_notifier_fdb_info emitted by drivers towards the bridge
Thread-Topic: [PATCH net] net: switchdev: zero-initialize struct
 switchdev_notifier_fdb_info emitted by drivers towards the bridge
Thread-Index: AQHXjSAoM5FylMZBM0itAyPu8B/6WKtsTdGAgAAX6QA=
Date:   Tue, 10 Aug 2021 08:16:17 +0000
Message-ID: <20210810081616.wjx6jnlh3qxqsfm2@skbuf>
References: <20210809131152.509092-1-vladimir.oltean@nxp.com>
 <YRIhwQ3ji8eqPQOQ@unreal>
In-Reply-To: <YRIhwQ3ji8eqPQOQ@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pWHW2jok8rYbQApHKaUuSd+fmQO7xlazRyVz85dwUxe7CV/UyQIWabz6/+o0?=
 =?us-ascii?Q?TIFopdW53XSStQJ1tfkiY+FoZ1vUlFjV1wYj/mHseD1rxfGX3Yd9OBqeVZ36?=
 =?us-ascii?Q?2IIyXqBQsej4n2L4tdbI8b3C2V3kAJKGD/Lp37vv/sESCMx5R8mLuA1gmf6B?=
 =?us-ascii?Q?fvPBgzB6RWat/qiW9rWUGOH+HhjLk68jCoRRbeVxOV7TBg7Rr/rF2MnSM7IW?=
 =?us-ascii?Q?lnQFKlipgFodmY0vzftY60Wj5iSBrYxiRL6JvGJa+IE+0kNjuhwmmNdm1g72?=
 =?us-ascii?Q?ZCQNO6CDXKY15WVD1Lff8w1DpCHRyif7cUeLu4cTzrseRbgGZls70UezpHRr?=
 =?us-ascii?Q?E3cA7fQbIe93bD9YNg0G7aKjh7YWmBTFVWJ5HMl+5G1ziPsNJRKg5hCdQ1+G?=
 =?us-ascii?Q?UYkFdzOoYLdKn9lv5OOP8hr0qN0VWoV8cbGTYXX3c7TfLysTy1ybNGlq6eGr?=
 =?us-ascii?Q?kukwMR3816kaiGMZUvRnSnw36mMX8N6S6/laO68WewRtuTvxqkjuXgUr39fX?=
 =?us-ascii?Q?VvfgYejtJHPxS8fgoCoSs4lwnUoT+bSysIVsRfW3QWlRTker7q9+40X989I2?=
 =?us-ascii?Q?aZmOFF8pQ57VQ/Gg/7oZ8/z/plNq0wK4N3Kdkm/e3kuXk7B3G+hT5B+R063U?=
 =?us-ascii?Q?5NWH+yQzg1Kgf04eMtnhT+61L2QDhrbX+xtLkn80UVzs23Ne9QP3f0kd/66X?=
 =?us-ascii?Q?othxX5tMLmZ/BfzwrXlZ5tJBLKR3YOHs2Ekfik8t9tKEwPvIoKIWK9kc0xXd?=
 =?us-ascii?Q?+cdMi+tz7baODRrXjlzzcXjb8MiMvs7n17D5q0X8+ZmWk036at4Vkoyy1Cpe?=
 =?us-ascii?Q?WAct9ORwoM3aswVKO0fG8ocbGPvL0YlVrrHwv95hCzSiHtlSoYHENmpMCCA+?=
 =?us-ascii?Q?tsj11tI1ulN1fY1hX/Jx94SGpiIPGcaiJYney6WFZNFGF6GEuOCG1ka2is+G?=
 =?us-ascii?Q?W+lNHf7CEb3ykl421qVpkP+Oxv2xTk+iPA0sqJUTh04fJD2m8OEjVGE7I7AZ?=
 =?us-ascii?Q?FUk43CYWUGzXPtSMicO+w6ceHJmRli2wZuQudUUkIrgGqPM5wGZ5eQSCce07?=
 =?us-ascii?Q?eWr4segt2Nzt3JgClKWaMMYGBotvFsGxFUSBGZ3XukgSbLC/G7jHgJkUdYM3?=
 =?us-ascii?Q?UQm/H/6nnKvvjGUTHVLAyg7Ep5DNTPf3GAaxefJXfky+1rQvlSvenzF4TdBH?=
 =?us-ascii?Q?OvXFdrTxh8hcefp3xl5QslNlpr9xTu96nyA8yNBtah+Nx3By+k8EEEa0kacq?=
 =?us-ascii?Q?RpOyaSbGZDTZoJ5VxZr50MILgoW0JGIGCPtl6U/OM3fEL3WcL1UhsbyBxF13?=
 =?us-ascii?Q?l/nv+a/r7q38tkFO8D5UBk5t?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <62A1A85FC8707541AD9E1BAF0D1C4E80@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e81c2070-3f94-4d74-7103-08d95bd720c9
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2021 08:16:17.5045
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4i054VArNdPxzoum9GcIiHfwo5qM58OwOrKfIePjxfro1H7mB8fCuoWNLzy2rwNTUTnEU383Xzw05eFQebOxdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2302
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Leon,

On Tue, Aug 10, 2021 at 09:50:41AM +0300, Leon Romanovsky wrote:
> > +	memset(&send_info, 0, sizeof(send_info));
>=20
> This can be written simpler.
> struct switchdev_notifier_fdb_info send_info =3D {};
>=20
> In all places.

Because the structure contains a sub-structure, I believe that a
compound literal initializer would require additional braces for the
initialization of its sub-objects too. At least I know that expressions
like that have attracted the attention of clang people in the past:
https://patchwork.ozlabs.org/project/netdev/patch/20190506202447.30907-1-na=
techancellor@gmail.com/
So I went for the 'unambiguous' path.=