Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Wong Vee Khee <vee.khee.wong@linux.intel.com>
CC:     Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net 1/1] net: dsa: sja1105: fix error handling on NULL
 returned by xpcs_create()
Thread-Topic: [PATCH net 1/1] net: dsa: sja1105: fix error handling on NULL
 returned by xpcs_create()
Thread-Index: AQHXjbEf97MxzK96ykqwDh6cpjl/jatsZyoA
Date:   Tue, 10 Aug 2021 08:25:29 +0000
Message-ID: <20210810082528.rff3aembgge62pd6@skbuf>
References: <20210810063513.1757614-1-vee.khee.wong@linux.intel.com>
In-Reply-To: <20210810063513.1757614-1-vee.khee.wong@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?X/f6qE3UsAN4HepdB7yh9m3eMXVhG0I14nAIwTyYnptJ53MB+KdlI0Pe/4lD?=
 =?us-ascii?Q?TbmKkaSN7U0oVNOjZZb9kaA429NZv196cyxfiEsZj/cODuZvh16+9pthRBFy?=
 =?us-ascii?Q?K+HHrrVHeU7FOdO54jKXvfVURb7EynEAAAgYGfxGEERvHZ+pxJU/ZIn+bXUu?=
 =?us-ascii?Q?sxY/vOfqOdXTbiOHn0Ay0/c+VmNp/6pktLtg7736JJazKK4nrjqTombq4DdW?=
 =?us-ascii?Q?uatamDbQN+bfOWQqDj2wXwSaJrYrsyFAmXGCk6mJILAVAHjicWxfvb+Oa802?=
 =?us-ascii?Q?BUKOzXcf3FLM3IjB/7cFF7032HDqYVSLZ4xW4e+1KNxSUEwi0h61spG7KzC/?=
 =?us-ascii?Q?a7s5oxXb47z+u1mw/ytjqRGfXQoltrv7LTCV3wdqKM/PdIDZd4zFyCu7DimN?=
 =?us-ascii?Q?JKc/qtT7bYRq3FvpGwQYEbVeJkHTE2rC1oWNz+aR72Kckgk+ZT+IOc0XYLEv?=
 =?us-ascii?Q?kpYaMQzkJRmz6QC1HweiRG+A+Jf5ux0cf9oE5F6t1SWNH9MvraeaS+mEsLEC?=
 =?us-ascii?Q?lKv+Hxg0mnjoSBVdAsO6GDGMXAKToMuSXSgk02om/SmlRtCQdiprGTsdVvKT?=
 =?us-ascii?Q?/AH9eSYP7kk1DTFCymik49aZGSChSqc9e8pon0h0gSEgWohc9KTEDwWLVo0e?=
 =?us-ascii?Q?hOMucllFVM4/TjuN2gSVzcR1aFM7gXD73VF06FnbJY8ouc2VueFyDhWLPENB?=
 =?us-ascii?Q?NS6IQjiNrWFUupBgEbHtfIB/oX1dtxlHkMvEfzsfFOON8Q6BlAwcFnoVWQXB?=
 =?us-ascii?Q?gfib0wz0Tu+GZKeDpRF13EtdB7m4WEuyZnO/fhFptetdlzJIPeuqVngbXdw5?=
 =?us-ascii?Q?Pzer+ygxi3C/jL83eER5/IJ0HpzCF7amBXQ2QXaKyLogv6QmxK5hOoEjqCys?=
 =?us-ascii?Q?NRkxUNOpmW6Mq1uyC43ahSoKa5HBuP4H0GDL3tJnGihAhmmzdZ47QgVPfa3e?=
 =?us-ascii?Q?u89yR6N3KV5XTTwuhJ5e3+9N2hiC7tyvvyNaf5qSGXnLbu8rVn5y5gH0I/tU?=
 =?us-ascii?Q?x8C9u9BUcyAoTNmBattsIUiZ169shR4ZYB524+RQJAcXdvbZ4B46jAhfMeD9?=
 =?us-ascii?Q?uuOgrUCa0+TWgS6VysMLd6+cChFajA5RuCLicPrRhcm5lt15gRdbzPmNg4iH?=
 =?us-ascii?Q?+oS3bjm+Ws9LT6N4E87vzwyE+vAuKNTauCr3/lLfjXQau/DHEAc8L50EOP0R?=
 =?us-ascii?Q?8hvTE0YYeK57o875l5VYRikvxT+FKlAgs3EHxVJtegmH7kXqDoUmExkZ2ltH?=
 =?us-ascii?Q?ntosqv3Yo5985AXLtgI1GTMryWzkPpHuMLpaHnXi97mvXeKFuDQ9+/4RdwZi?=
 =?us-ascii?Q?sRpnW9miJITp3FEThXFB2Rc6?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <04C31B26DBAD834F8DC02C5439A0482C@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10e379a5-b813-4edc-3185-08d95bd86993
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2021 08:25:29.1144
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4/qxEFluWh2k9pMI6WmWOGuuOk4WlfC/mM+UFn0bzVpTJ0fRqPkHbWm8IxRRztZAxvzes1svxYY1jRldC9u/ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3070
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi VK,

On Tue, Aug 10, 2021 at 02:35:13PM +0800, Wong Vee Khee wrote:
> There is a possibility xpcs_create() returned a NULL and this is not
> handled properly in the sja1105 driver.
>=20
> Fixed this by using IS_ERR_ON_NULL() instead of IS_ERR().
>=20
> Fixes: 3ad1d171548e ("net: dsa: sja1105: migrate to xpcs for SGMII")
> Cc: Vladimir Olten <vladimir.oltean@nxp.com>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
> ---
>  drivers/net/dsa/sja1105/sja1105_mdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/dsa/sja1105/sja1105_mdio.c b/drivers/net/dsa/sja=
1105/sja1105_mdio.c
> index 19aea8fb76f6..2c69a759ce6e 100644
> --- a/drivers/net/dsa/sja1105/sja1105_mdio.c
> +++ b/drivers/net/dsa/sja1105/sja1105_mdio.c
> @@ -438,7 +438,7 @@ static int sja1105_mdiobus_pcs_register(struct sja110=
5_private *priv)
>  		}
> =20
>  		xpcs =3D xpcs_create(mdiodev, priv->phy_mode[port]);
> -		if (IS_ERR(xpcs)) {
> +		if (IS_ERR_OR_NULL(xpcs)) {
>  			rc =3D PTR_ERR(xpcs);
>  			goto out_pcs_free;
>  		}
> --=20
> 2.25.1
>=20

I think posting to 'net' is a bit drastic for this patch. I agree it is
an issue but it has bothered absolutely nobody so far, and if sending
this patch to 'net' means you'll be blocked with your patches until the
'net'->'net-next' merge, I'm not sure it's worth it.

Anyway, I don't think that PTR_ERR(xpcs) does the right thing when
IS_NULL(xpcs). So how about you make this change:

-----------------------------[ cut here ]-----------------------------
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/ne=
t/ethernet/stmicro/stmmac/stmmac_mdio.c
index a5d150c5f3d8..ca12bf986d4d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
@@ -415,7 +415,7 @@ int stmmac_xpcs_setup(struct mii_bus *bus)
 			continue;
=20
 		xpcs =3D xpcs_create(mdiodev, mode);
-		if (IS_ERR_OR_NULL(xpcs)) {
+		if (IS_ERR(xpcs)) {
 			mdio_device_free(mdiodev);
 			continue;
 		}
diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c
index 63fda3fc40aa..4bd61339823c 100644
--- a/drivers/net/pcs/pcs-xpcs.c
+++ b/drivers/net/pcs/pcs-xpcs.c
@@ -1089,7 +1089,7 @@ struct dw_xpcs *xpcs_create(struct mdio_device *mdiod=
ev,
=20
 	xpcs =3D kzalloc(sizeof(*xpcs), GFP_KERNEL);
 	if (!xpcs)
-		return NULL;
+		return ERR_PTR(-ENOMEM);
=20
 	xpcs->mdiodev =3D mdiodev;
=20
-----------------------------[ cut here ]-----------------------------=