Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3507666pxt; Tue, 10 Aug 2021 05:24:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxotI8yYoQO217umNLO47+6v7WWmU10y/GLHhL43K6QPg4mEEdoz07d8Hl1hYokn0e5Id5H X-Received: by 2002:a5d:990f:: with SMTP id x15mr312384iol.200.1628598297769; Tue, 10 Aug 2021 05:24:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628598297; cv=none; d=google.com; s=arc-20160816; b=G73qF169xaCUdZb7r6MrPf3lNgNpUJJ/1BvtsMhyrHc9GwOv9TcxNDOHTrCVAyMDKh tOgbzguHPtxEAWmSfZQ3ifX8Y2FG4H7KONgB+seh01DZDXTlk/epEYq3nxe5B0ZqQQwT MvZhU+AqT6QLsaUKjSubVCVtdCBRCgZIRST8J2P3u85sjSJ68qOmWlCdEl3y/zMDDlo2 64VYpYihyONEiyKoQCNU028XlIjewK04YRWSg1uupDmmmyL4IAIGofsSenaPBrqokukI aB9D/B5EdTnGNj4Bcn28MwbAVY0Bv2MOR8giVhr1cmRCtTuzxPJXnUUZ1vQr8F4fdWCc fJ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=9dXulaCUrPQVyS2CV9G2NLUra2wYA+aHq+Rs95/WQoM=; b=tzDCIPY1zq/4WG5fL7EvBJ2RWjBKVdprxmV0VFM13ZCwJnE6UMnWQkaldG/oCiSS7f +l0UmBmoUZb9esuckKdHl0ojknDs0GkyAfDKEv2orAxgWgKP5cy0rCfSyTwzR9JQH9RU k8acxqFfd+BZtI/dSJaF9z9/zQvoXf74IQfc8IdYkEGkoE3Jajpb85h7xnBcMAw1hkB4 AUyJqjbLbowPkFX+BUtrmXIgaequlU8Fdp0/TsVKqNLdnjkxbNVF7I1VMv1Dd0U7rSRI ikB9oCeZoJ7acYq5dsdtddnzLh7ItLtadGHpBbXwwH4npuhIpbKaf09lFOgA3lLk/Kv+ XTOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q9si2131307ile.120.2021.08.10.05.24.46; Tue, 10 Aug 2021 05:24:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238539AbhHJJDD (ORCPT + 99 others); Tue, 10 Aug 2021 05:03:03 -0400 Received: from verein.lst.de ([213.95.11.211]:35309 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233739AbhHJJDC (ORCPT ); Tue, 10 Aug 2021 05:03:02 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 88C5768AFE; Tue, 10 Aug 2021 11:02:34 +0200 (CEST) Date: Tue, 10 Aug 2021 11:02:34 +0200 From: Christoph Hellwig To: Konstantin Komarov Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz, aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org, joe@perches.com, mark@harmstone.com, nborisov@suse.com, linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com, dan.carpenter@oracle.com, hch@lst.de, ebiggers@kernel.org, andy.lavr@gmail.com, kari.argillander@gmail.com, oleksandr@natalenko.name Subject: Re: [PATCH v27 02/10] fs/ntfs3: Add initialization of super block Message-ID: <20210810090234.GA23732@lst.de> References: <20210729134943.778917-1-almaz.alexandrovich@paragon-software.com> <20210729134943.778917-3-almaz.alexandrovich@paragon-software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729134943.778917-3-almaz.alexandrovich@paragon-software.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static struct dentry *ntfs_mount(struct file_system_type *fs_type, int flags, > + const char *dev_name, void *data) > +{ > + return mount_bdev(fs_type, flags, dev_name, data, ntfs_fill_super); > +} > + > +static struct file_system_type ntfs_fs_type = { > + .owner = THIS_MODULE, > + .name = "ntfs3", > + .mount = ntfs_mount, > + .kill_sb = kill_block_super, > + .fs_flags = FS_REQUIRES_DEV, > +}; You can't add new callers of mount_bdev or users of the old mount support. Please switch to the file system context based API before resending. Take a look at e.g. XFS for how to implement it.