Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3560531pxt; Tue, 10 Aug 2021 06:26:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3XvdpbNLg4oQdUsqbCnb/B/IJnDFJp5QPEYaPPisII9HnTon5b6NJAWSS9shNf6LgM48Q X-Received: by 2002:a02:1083:: with SMTP id 125mr1931591jay.34.1628602011344; Tue, 10 Aug 2021 06:26:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628602011; cv=none; d=google.com; s=arc-20160816; b=N52J+9keOnCTznLRrMrZLeIlUWK4ncylNW+kmpAGFm3SyNHsvcH2nr5UL09PYLDoiC Xys+rpABPh2Bo3FifT/bEhILfAcwySBEIQwMiSw2JMwnw+1y7WJdG9Oz+hr0TxRDlmE0 3CJfHOBH+tQcR8X+HoUT6/0THDP5PkDi0bd8mobMl3jpJaX3t2wzceFB+sLG+JRgSh+z ubGRZpZsD4dFdJWKiXQ6JKi3H2hYrt+324oUe7Z2LwNhMRYguXDVjzswFQJRUa0fMdDU FgputX8RcvppWYxnjAPjLjZTNJME63O0UvUS8smEyJD8KxB7MFGwZhkjps7do0Y31nbv sIkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9MK0Nz2xYrO+wOufoNzpiWcDVdlXMm2JN9j80slkAmY=; b=DUWmUIJbOCGjdVexyVubxgRsoZtckNzmXMIzVXKTud95e/Cpix2m5a5SdwM0Ivx5zo asGW1znkrVOwihK6rUcVxLj5JU9mvSZjPkNJApjmWBadMvKEBFUUo30ehRt0h8+ajv1p u00aEm8wx6pRNfVYHVQWhuxOVkmUsKbuCNuo6H1PItEAgxOMcDIybUCLVnDbqLexU1nq LcqbBCeoWODzDC5H47CkTVtZLJUwvBcwvW0u1FJVMc2X+hO1aC1kDaYxGp5VIpLiyo6u BtoXWKf1ACvnQa/833Agi6jleAXZ0v+3hXiK/allMEirnumfeBKEM+zuqank/ejxqKFO 5Y2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HEcHyhYj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si12056606jak.114.2021.08.10.06.26.39; Tue, 10 Aug 2021 06:26:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HEcHyhYj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238874AbhHJKTa (ORCPT + 99 others); Tue, 10 Aug 2021 06:19:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:49886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238920AbhHJKT0 (ORCPT ); Tue, 10 Aug 2021 06:19:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C6206108F; Tue, 10 Aug 2021 10:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628590745; bh=9CIYaoUk3OsY+BjiTGw8q0Huaalf7bY8/x0CBVVHlI4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HEcHyhYjtQz+a+HeSkTIh91M3Cso18O/SugDnEbx0canubN2xtecscTSm4r914SuY faCtbl+EnNl3X/fhMHTSaPJeIYRaGPsIvzyBkARY2pb+37VY4GNTlva76lw4yxcwNr uaty7syo7uVh4xMPAXdOsW4YjUI0xtjylZBmhOfs= Date: Tue, 10 Aug 2021 12:19:01 +0200 From: Greg KH To: Larry Finger Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: Remove some dead files Message-ID: References: <20210809210912.1022-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210809210912.1022-1-Larry.Finger@lwfinger.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 09, 2021 at 04:09:12PM -0500, Larry Finger wrote: > The porting of the new version included 3 source files that are > only used for testing of the device. They are not needed here. > > Signed-off-by: Larry Finger > --- > drivers/staging/r8188eu/Makefile | 3 - > drivers/staging/r8188eu/core/rtw_mp.c | 974 --------------- > drivers/staging/r8188eu/core/rtw_mp_ioctl.c | 1170 ------------------- > drivers/staging/r8188eu/hal/rtl8188e_mp.c | 798 ------------- > 4 files changed, 2945 deletions(-) > delete mode 100644 drivers/staging/r8188eu/core/rtw_mp.c > delete mode 100644 drivers/staging/r8188eu/core/rtw_mp_ioctl.c > delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_mp.c I get the following error with this patch applied: ERROR: modpost: "rtl8188eu_oid_rt_pro_set_data_rate_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "rtl8188eu_oid_rt_pro_set_single_carrier_tx_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "rtl8188eu_oid_rt_pro_stop_test_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "mp_stop_test" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "MPT_InitializeAdapter" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "Hal_GetThermalMeter" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "Hal_SetThermalMeter" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "MP_PHY_SetRFPathSwitch" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "rtl8188eu_oid_rt_get_efuse_max_size_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined! ERROR: modpost: "rtl8188eu_oid_rt_pro_trigger_gpio_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined! WARNING: modpost: suppressed 46 unresolved symbol warnings because there were too many) Are you sure those symbols are not used? thanks, greg k-h