Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210808015659.2955443-1-liambeguin@gmail.com>
 <20210808015659.2955443-4-liambeguin@gmail.com> <20210808173630.5c384a4b@jic23-huawei>
 <CDEHT583QT0A.2QAXX9AC2FMLO@shaak>
In-Reply-To: <CDEHT583QT0A.2QAXX9AC2FMLO@shaak>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 10 Aug 2021 15:15:36 +0300
Message-ID: <CAHp75Vc3o-RrHD_wt_CfJY3P8hoRhJkdiRRySFS_O_7VdtJTQA@mail.gmail.com>
Subject: Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref
To:     Liam Beguin <liambeguin@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>, lars@metafoo.de,
        Michael.Hennerich@analog.com, charles-antoine.couret@essensium.com,
        Nuno.Sa@analog.com, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        robh+dt@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 9, 2021 at 1:50 AM Liam Beguin <liambeguin@gmail.com> wrote:
> On Sun Aug 8, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:
> > On Sat, 7 Aug 2021 21:56:57 -0400
>         ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
>         if (ret == -EINVAL && mode & AD7949_CFG_VAL_REF_EXTERNAL) {
>                 continue;

>         } else if (ret < 0) {

Side note, redundant 'else'

>                 dev_err(dev, "invalid voltage reference in %pfw\n", child);
>                 fwnode_handle_put(child);
>                 return ret;
>         }


-- 
With Best Regards,
Andy Shevchenko