Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     martin.petersen@oracle.com
Cc:     baijiaju1990@gmail.com, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org,
        Linux Kernel <linux-kernel@vger.kernel.org>
From:   Tuo Li <islituo@gmail.com>
Subject: [BUG] scsi: iscsi: possible null-pointer dereference in
 iscsit_tpg_add_network_portal()
Message-ID: <89aaa039-2f03-f657-a555-a6a99f38db6d@gmail.com>
Date:   Tue, 10 Aug 2021 21:48:03 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hello,

Our static analysis tool finds a possible null-pointer dereference in 
the iscsi driver in Linux 5.14.0-rc3:

The variable tpg->tpg_tiqn is checked in:
496:    if (tpg->tpg_tiqn)

This indicates that it can be NULL. If so, a null-pointer dereference 
will occur:
508:    pr_debug("CORE[%s] - Added Network Portal: %pISpc,%hu on %s\n", 
tpg->tpg_tiqn->tiqn, ...)

I am not quite sure whether this possible null-pointer dereference is 
real and how to fix it if it is real.
Any feedback would be appreciated, thanks!

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>

Best wishes,
Tuo Li