Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3624703pxt; Tue, 10 Aug 2021 07:45:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMHApVdrICsk70B24AuKX+D8aVVawqTF9hw9B/d2E7O5B2f4Ftnizh62ZerW21TjQdiPmf X-Received: by 2002:a17:906:1f82:: with SMTP id t2mr27405477ejr.499.1628606744074; Tue, 10 Aug 2021 07:45:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628606744; cv=none; d=google.com; s=arc-20160816; b=RFHstsU0N/Gv+9A9XEaFM/f0frbOHPJ2I5bmWR3s+egyNbxMMMN1wBF748KjDo4kfu LN/xRxSi8PnYfB4QYo8K3SqO39t88p62pgQfl36yXd7PA+yX6CFm0cVkKepvbJ4q76Ol J9gDozJqGTg8g1S4rxeBKsSKj/7agfxddGQFkDI2pzOf6mtEbf4neps91dCxLyeVIWsE Vwudj+gfxHbKZlmzLU4q9e314CW+f2G0rL9VyWVFOdeE4PVmzTfSEuJbUTzNbcaDzQGz N6NUnKGyB30Nvh0B6txsC2rF37ZN2R/zDVmp+G9+fSA5eD3Hi8W/JbI/6ieSIP2MaUlw fYsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Q8au1ii1909Hv5Z5/rx5+fAdNdc86VXlXvIbiV+46+c=; b=l7P8kUL7PH35TO8tCDJzKemwMlQYdh3KIDUF9Ua1XsMHTK1MMz9jVr34ocG7yBy7K8 DpCvix48i+lehz9oO29+MIGcagMkkvMv+TOOnZDBQZN0l4403zZefNVzyqcLsoOivOkf sN/lymM5W9ELatiEQ58+dHDnwlTszN8A+2VLeihnlA/iX2d+IakCVV3awGN+fBi3tPd8 BgLYwc0LRQjZYwr/2bVLSDIDvXFYugAcoAoFOa9o5Cte4RmCx8gliQgTOevbS8AqoILL vQFq4Ke3+XKDKwM++kECz8K7HjOo9n6IgBsjfcrtT2EuLdRdB4lyBpWDBJw693Mu3WTu yvlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p16si17853409edr.38.2021.08.10.07.45.18; Tue, 10 Aug 2021 07:45:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241321AbhHJOXi (ORCPT + 99 others); Tue, 10 Aug 2021 10:23:38 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:17002 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243206AbhHJOSb (ORCPT ); Tue, 10 Aug 2021 10:18:31 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GkZhN34Tzzb0WH; Tue, 10 Aug 2021 22:14:28 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 10 Aug 2021 22:18:06 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 10 Aug 2021 22:18:06 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next] spi: mxic: add missing braces Date: Tue, 10 Aug 2021 22:24:05 +0800 Message-ID: <20210810142405.2221540-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following waring: drivers/spi/spi-mxic.c: In function ‘mxic_spi_mem_exec_op’: drivers/spi/spi-mxic.c:401:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if (op->data.dir == SPI_MEM_DATA_IN) ^~ drivers/spi/spi-mxic.c:403:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ if (op->data.dtr) ^~ Signed-off-by: Yang Yingliang --- drivers/spi/spi-mxic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-mxic.c b/drivers/spi/spi-mxic.c index 32e757a04f14..45889947afed 100644 --- a/drivers/spi/spi-mxic.c +++ b/drivers/spi/spi-mxic.c @@ -398,10 +398,11 @@ static int mxic_spi_mem_exec_op(struct spi_mem *mem, if (op->data.nbytes) { ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1) | (op->data.dtr ? OP_DATA_DDR : 0); - if (op->data.dir == SPI_MEM_DATA_IN) + if (op->data.dir == SPI_MEM_DATA_IN) { ss_ctrl |= OP_READ; if (op->data.dtr) ss_ctrl |= OP_DQS_EN; + } } writel(ss_ctrl, mxic->regs + SS_CTRL(mem->spi->chip_select)); -- 2.25.1