Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Aug 2021 17:43:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org
Subject: Re: [PATCH -next] staging: r8188eu: Use GFP_ATOMIC under spin lock
Message-ID: <20210810144316.GW1931@kadam>
References: <20210810125314.2182112-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210810125314.2182112-1-yangyingliang@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNAP275CA0028.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Tue, 10 Aug 2021 14:43:32 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 006c9882-b090-4859-7702-08d95c0d3d66
X-MS-TrafficTypeDiagnostic: CO1PR10MB4402:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB44026AB46F6A3708571FF21B8EF79@CO1PR10MB4402.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1186;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lxwz6UoLCcAYHPJUGyGBo+z5za+bCCBSYBNtXWttlSgptfpNFDOy0/sF477l4HuZ5v4REYtbPbudKU4sp+0UVRMUHKBn2/5+jUHc+gZVeElYriASwUgrHzLZjczFIVtg9v5Wle3d0a0h6ir0UOW2xsHsA/NjOAWdhIUf/v+3wyMmHRHRK8+MDx1MSuwERbzKUYolLp8USivpOuJslSVRIeC6vNnCZ5bSvET3y0Wxd+57t+VDgONrYxf7G/rLARea+uBt0Bypy1PkfP5oF6MUqiB2sHUf74Qhpb8Zb8j6/rzoC7chKjOKIERaqKHBFhr/6phiOOwwgFpQA/3/y3ISmbE2TG06MyK6S/39shW1XtxQJHzr3YyuL2oo/TcdpW6odlvTPk3z16nMcYQJv8qTfP9I993ZWKF0YrtOXNVATVWoFdBAeQGlbElO4Jtn14Arlslt51Wz1C/AFmc9Fg2RztdhJqOX8GLd7gTkeNIj0nSpuxf95uQUCZ5yJM38PFbP++0HmAZ0MY8qU0b/E0Rpd+DmAIh8i8ebt58vjLPitNPCD2h03FpAtGQJ6XNS+wo51y90mQwAqEPOJfe2/FQpUbJAj/dhZupkITsz8oHkX98IRGKNUzPKbIx48x8nIstyQIFOdoDlhk2Gic/ipK431m/R8sbQS9rkVrKg+c2meFn+O1MX/fGuvvpD7txd9Aq8BUQJufYshuXuwRRqWuB1Sg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(376002)(396003)(136003)(39860400002)(26005)(478600001)(86362001)(316002)(9576002)(6666004)(186003)(6916009)(1076003)(4326008)(5660300002)(956004)(2906002)(4744005)(33716001)(6496006)(66946007)(66476007)(8676002)(55016002)(8936002)(9686003)(52116002)(44832011)(38100700002)(38350700002)(83380400001)(33656002)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DZy7wUAG3STPVDwvHSLortXt9x0Jrd1qJ2+a7I/iFm5fsDr/lPQz3ENS4xM1?=
 =?us-ascii?Q?IDq0L5aeAOb0cb9qD9stcCYL8LQB+X64kjb2Qm/X+FQZU5k5B9DJBDvfQAW2?=
 =?us-ascii?Q?t99Gbqc5oya7LWfXTenky2fnAloRHd7+5dN6xC0K1IOvr4l1FesE1TMVXY6x?=
 =?us-ascii?Q?Hj/wV0X5b0x8yO2JNic7thnrPSC6wKQEN9jlSzgUYNdWr8DKwFAmRu3qTwvI?=
 =?us-ascii?Q?VFNlDwoPpfejcHzYyW73wFHsJlh1QchoXsVxdsdn+Hb7jCq3TsTfz6kpUB66?=
 =?us-ascii?Q?QAEdOOD++U4QhzsoMl0YzZoH8gGlWObL2eoPcOqqIDfUItqQ8O3j4Q0SjpN6?=
 =?us-ascii?Q?IYOLqX3OQGRAYGqgBu2BHfFr9Z//rYjL8gL8KZNce2p1SG0EiKOBI9fdYmne?=
 =?us-ascii?Q?7q6mnTBrz6mWLpnIca2Vjy8pVF2z9ALzu5ctX21NfvbX8mZP9sI3hTeVtBaY?=
 =?us-ascii?Q?d/R44kiXOKt7fPMoPhN8VT85y5emNjfDwqFwiAK3uK7WcCKYE0zfsZCftS8d?=
 =?us-ascii?Q?TYVKCYlgU8RbtHVod/Pv+C5htxPFI9UE4HFtj6T+F4iP51pXjXvfQ3afECZk?=
 =?us-ascii?Q?G9XsXOvh8pY3jqDLLSevrKxbSeyqBy0i7VdEK6n13NvlO/gNjg5gIXQb3P50?=
 =?us-ascii?Q?EWTYKZ6gAO5eRBIqaYMRzfdkoyImLtB8Axd+ca0fhJMD+aUddR6s/AtsHsM3?=
 =?us-ascii?Q?kzm37CH1Z8GNCX1RKhrLzetTmonZ7ZdEgmkV17wBTGp3r2ukI0vDOIG97EWN?=
 =?us-ascii?Q?rkeAzYkQVipaysy4F6TPTy1jERMK/q1C/GdrD17G8t/KJk06qun0jYmR9D0V?=
 =?us-ascii?Q?EX/2rYAuSBYqa/mP/uYgHp7RTh94Q9iK+1TlSwoYoA2as8uHtgcIS8Tugkq9?=
 =?us-ascii?Q?9BgUVe70ZJDn2mNc/4Q+XIcRpAcDqOLTX/0EyNs8anxuS6FEQr+w+7p78gef?=
 =?us-ascii?Q?T4WIFOMZvDwstfWNV0cwQxofmO9I2VkL1rrguUOONUuPsYv/NnCRXJKlbDZC?=
 =?us-ascii?Q?CuSmh5bHW1hHQlmf8pVXl5jjkYetUAcLD71zqhzrJXNv9fZM4eyzHlYDQmrd?=
 =?us-ascii?Q?OTk+qDZT3c1DO2s5uKGiuDFPeYON2RTq18ZrNj1CFq6by2Y8jfbSH+ryoiqU?=
 =?us-ascii?Q?osaVbKuk+flYFZpBLxR8g5l9BkSC0k4bzLNkD2uzpHDbz4gzg8NE47rKN/8J?=
 =?us-ascii?Q?4EtUzAb7SyPv/wSOTGlRvi+H135NxTir2YaCaJUPE8xfvxskF+iiRdKvN/fs?=
 =?us-ascii?Q?sB/kCbRZ3jfz38pvT5nPpwpTQhWzIKviqUTHciIHozxID2LL/PiTlpyqSy6N?=
 =?us-ascii?Q?TBiIZMPzcv0PV6bsQiK+2Wfp?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 006c9882-b090-4859-7702-08d95c0d3d66
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2021 14:43:38.7339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MVdnexLkyJH5savarcO2b/jCzcunvkkQwAvQbM2/ecyf6YSbcIof2eRw0Cf7AS6zvNI9GA23m6MmUfgL3mgTgkxUglGHh/QlCt+OVsapEPI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4402
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10072 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108100093
X-Proofpoint-ORIG-GUID: v4V-DwszaXsvw44MgQvzNe5xh3qXAV_0
X-Proofpoint-GUID: v4V-DwszaXsvw44MgQvzNe5xh3qXAV_0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 10, 2021 at 08:53:14PM +0800, Yang Yingliang wrote:
> A spin lock is taken in __nat25_db_network_insert() and
> update_BCNTIM() is called under spin lock so we should
> use GFP_ATOMIC in both place.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Good spot.  This goes back to the original add a driver commit.  It used
to call rtw_malloc() but that was buggy.

Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter