Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210810095832.4234-1-hpa@redhat.com> <20210810095832.4234-10-hpa@redhat.com>
 <YRJPebbK3uQBU9K8@lahna>
In-Reply-To: <YRJPebbK3uQBU9K8@lahna>
From:   Kate Hsuan <hpa@redhat.com>
Date:   Tue, 10 Aug 2021 19:43:42 +0800
Message-ID: <CAEth8oE5we991RS12AJdFHtfD4kJkzFd4A0wHdEFKkX-i6kmvg@mail.gmail.com>
Subject: Re: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to
 increase readability.
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        Alex Hung <alex.hung@canonical.com>,
        Sujith Thomas <sujith.thomas@intel.com>,
        Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
        David E Box <david.e.box@intel.com>,
        Zha Qipeng <qipeng.zha@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        AceLan Kao <acelan.kao@canonical.com>,
        Jithu Joseph <jithu.joseph@intel.com>,
        Maurice Ma <maurice.ma@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Daniel Scally <djrscally@gmail.com>,
        linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com,
        platform-driver-x86@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Mika,

Thanks for your suggestion.
I'll add them to the patches and resend them again.

Thank you.

BR,
Kate

Kate Hsuan

PhD

Senior Software Engineer

Red Hat APAC

Rm. 2708, 27F., No.9, Songgao Rd., Xinyi Dist., Taipei City 110

kate.hsuan@redhat.com
M: +886-919560388


On Tue, Aug 10, 2021 at 6:06 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> Hi,
>
> No objections, I think this is good idea but..
>
> On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote:
>
> .. I suggest to add proper commit message here. Many maintainers ignore
> patches that don't have one.
>
> > Signed-off-by: Kate Hsuan <hpa@redhat.com>
> > ---
> >  drivers/platform/x86/Kconfig                  | 47 -----------------
> >  drivers/platform/x86/Makefile                 |  6 +--
> >  drivers/platform/x86/intel/Kconfig            |  1 +
> >  drivers/platform/x86/intel/Makefile           |  5 ++
> >  drivers/platform/x86/intel/scu/Kconfig        | 52 +++++++++++++++++++
> >  drivers/platform/x86/intel/scu/Makefile       | 11 ++++
> >  .../x86/{ => intel/scu}/intel_scu_ipc.c       |  0
> >  .../x86/{ => intel/scu}/intel_scu_ipcutil.c   |  0
> >  .../x86/{ => intel/scu}/intel_scu_pcidrv.c    |  0
> >  .../x86/{ => intel/scu}/intel_scu_pltdrv.c    |  0
> >  .../x86/{ => intel/scu}/intel_scu_wdt.c       |  0
> >  11 files changed, 70 insertions(+), 52 deletions(-)
> >  create mode 100644 drivers/platform/x86/intel/scu/Kconfig
> >  create mode 100644 drivers/platform/x86/intel/scu/Makefile
> >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%)
> >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%)
> >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%)
> >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%)
> >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)
>