Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3715387pxt; Tue, 10 Aug 2021 09:40:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+nFnyv7diKFtsByNT3H5n8s9lOfelqmJZdUIEPUkmBjrIxI3ncUTcYnKUclSpx7WX/ZIi X-Received: by 2002:a92:7c03:: with SMTP id x3mr111368ilc.47.1628613601348; Tue, 10 Aug 2021 09:40:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628613601; cv=none; d=google.com; s=arc-20160816; b=T9SnC1qNhnGC3+pg+wk/qAO5itiGk3QRgMwuPgfRHgfjFycqP7Odfa5eNvggt392D9 DqkbLkT3S/gfLuUdSHxjX/NiArBBc3JpFiOMKPvmn3J8Lrj99iYmmYESyBofWn3aSqjJ xbBPKVGHBuKzqDd0VbwdAfr/Ww5/hQU3GId0+3o31m3BZdP9xIwHrAhIZz/weJF9mpZa 0tuRz6Hpuy9c4W2LcKIPo9kAUrY0BPqRG9ZRRONr7bk1t3wjASSkkDvWD/KYifPeDOIk 6ue3QLOLIMrwSK9fLUgbkO8Fv9rU4+1X4xr2g5AXj+JzWgLWBOr5YNZLv9iRE3C/MEwT ilkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=JlbxbHhUxsF6/leU6+ftETUxYgZkp1F5/5GlQ7SbXsY=; b=KyKGiAy/cRy0fom2ohj/5DJcPfUzf1oxaiOrIAb1gXf/zNCMXKhpIXl82mNFhY76kF XB4xMd112n+8PFLNl0fYST2rzQKpoORY6ujkchiNom7f4X95T2gIByASWe+3t8oXz876 E7L4D7HOIdo0QqDWszYbX7sp0JLEMT2DWwLk7Fvpb7R1v0fx9fgoJR0bSyvInh1PxNK0 GEdgjETB1sm2dW+mP/H6AIWJcfu6NZ2ngLdAud2igKJ/hjGLy9xadogImrAEdHWMnitB TFLCT6kRndDz/EkCCa7Nu55L4szML/Em9IqITsTpR89UaOOc3xe/X0+Tj75Eh8g/ATY5 dS0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=neYehoZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z4si22505984ilo.41.2021.08.10.09.39.49; Tue, 10 Aug 2021 09:40:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=neYehoZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241875AbhHJOsA (ORCPT + 99 others); Tue, 10 Aug 2021 10:48:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:40098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241835AbhHJOr7 (ORCPT ); Tue, 10 Aug 2021 10:47:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 142F660F25; Tue, 10 Aug 2021 14:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628606857; bh=w2Dz/2K8UpCBs+YfXsHYqixApJ1UabAsDWwqZ5GOGyI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=neYehoZJC+E+pom8FC2YzXkQeIOrdOO7f+qVKzLZmEYJMjBxZ3I6HshcemhSxjCX0 cn7jNIFb9KFfBgpbsyaoahvkXD5tRe//TyLYS3fduF7Kae1TVR7/Nn0qzkOcT1bv5j z7n0j9PQCAEwNrO9ey7gKp0xXVZG77mda8bMx2GNnPJ4W+uEn+npiELJdIw1DAtZHA sZfEVEYLU38IupNn9xFdjwo0AJCM0s2F2GFUixswhe0bbNzM2RqtSD4RsU2GjeDsyC rJ51mWmnVpa8FE1ERvvXDheCmhObDznChfl1PE+1Vbq3+kdPtRYjZ6NWH019pLN2TK dUHAF1oUhnWHw== Date: Tue, 10 Aug 2021 09:47:35 -0500 From: Bjorn Helgaas To: George Cherian Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, bhelgaas@google.com Subject: Re: [PATCH] PCI: Add ACS quirk for Cavium multi-function devices Message-ID: <20210810144735.GA2264304@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210810122425.1115156-1-george.cherian@marvell.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 10, 2021 at 05:54:25PM +0530, George Cherian wrote: > Some Cavium endpoints are implemented as multi-function devices > without ACS capability, but they actually don't support peer-to-peer > transactions. > > Add ACS quirks to declare DMA isolation. > > Apply te quirk for following devices > 1. BGX device found on Octeon-TX (8xxx) > 2. CGX device found on Octeon-TX2 (9xxx) > 3. RPM device found on Octeon-TX3 (10xxx) > > Signed-off-by: George Cherian > --- > drivers/pci/quirks.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 6d74386eadc2..076932018494 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -4840,6 +4840,10 @@ static const struct pci_dev_acs_enabled { > { 0x10df, 0x720, pci_quirk_mf_endpoint_acs }, /* Emulex Skyhawk-R */ > /* Cavium ThunderX */ > { PCI_VENDOR_ID_CAVIUM, PCI_ANY_ID, pci_quirk_cavium_acs }, > + /* Cavium multi-function devices */ > + { PCI_VENDOR_ID_CAVIUM, 0xA026, pci_quirk_mf_endpoint_acs }, > + { PCI_VENDOR_ID_CAVIUM, 0xA059, pci_quirk_mf_endpoint_acs }, > + { PCI_VENDOR_ID_CAVIUM, 0xA060, pci_quirk_mf_endpoint_acs }, Is there a plan to add ACS capabilities to future devices, or is Cavium just resigned to forever adding and backporting quirks? > /* APM X-Gene */ > { PCI_VENDOR_ID_AMCC, 0xE004, pci_quirk_xgene_acs }, > /* Ampere Computing */ > -- > 2.25.1 >