Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3718578pxt; Tue, 10 Aug 2021 09:44:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAxTFQOucATgPPNxQNf0OiJYv8wXL7a/X7oDeVD1wnoX1EV5bD69vNeX4yZXIYwLoLUFYB X-Received: by 2002:a05:6e02:1cab:: with SMTP id x11mr147874ill.235.1628613867727; Tue, 10 Aug 2021 09:44:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628613867; cv=none; d=google.com; s=arc-20160816; b=eHIhcpOoy5e3jB6rkv3U8oD1Js9SAzb7TI73ukcmbvm0L4xF6SqYhiPQQOW9fw9HL9 HPk8Jzs+xIWDo+jEntnZC4TPmPk0cB9iPgRcHgFqUNgyFPKPH7bg+oR8CCcBzNd3E7lh h6Q6gxXL3C+P+K9tS4E7vo55A6R58bnDPyTLJsDuBNhbXj1FWgBFgHOkd9fK+dBNquCl 5L7JCRSZ/4QPAzVbz38/MWlnNr2hj/l0rVXkMewIHwH+7iIiyMNFttqObkGz+XGcdLFO upFpkEav3S179JdokE2O2Pe7qoJ+LO5KDV3cpUF/2wgVAj7d930vuy4McX2lbugdIafV +QNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=QFMIGRol7sV7/3Q+36hwNIwNbBlX+rl3ShevG/F9H84=; b=yxaHY3jSb/uPyVSg+/sLqeaVrMr+CME3Eo+c92mF53H/H3zP/ulpqxB2qSQQ1MN4Q4 EiVHd+/lm60LETMQPdf6NajcDcaOmZlHqT9QlonRwfSLuolNJS+NArGKRmA3hsgSjCzM WwS+PMxx3Za185+dLKKhhPesVPNRTfdNTPTMAq+ZzGW/6STf62tPQvKcqm3swoSB7Pje 0eVC6dR6flWRuPc/2kmu8f7o4e7IXtBOXmDKAfK2JDodj4j2q2EXrM64SzdH0S8WXebm xjP9e/B9v8oqMFWqebNZsZWwBBvx3dn/RP+ZfgW1mbpI0bH4bDdWkKf8O9dNM3UMmbSo BYCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rp8AUGfN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si20451329iot.101.2021.08.10.09.44.15; Tue, 10 Aug 2021 09:44:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rp8AUGfN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243226AbhHJPz6 (ORCPT + 99 others); Tue, 10 Aug 2021 11:55:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243081AbhHJPz6 (ORCPT ); Tue, 10 Aug 2021 11:55:58 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1310C0613C1; Tue, 10 Aug 2021 08:55:35 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id t128so29476603oig.1; Tue, 10 Aug 2021 08:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QFMIGRol7sV7/3Q+36hwNIwNbBlX+rl3ShevG/F9H84=; b=rp8AUGfNdqWi0MkQHN2MpjPflMt1qnkgOles5T9lsTu7PsejD7ghbNg/xG2w7Um8ic HqDOUHBqhfjr05ZiDYbFo69NLpW2ip3OIty+nU6mQeBeflrtuXZ4nuZyXolyVo8hf8tQ VYuw5Cnok2i7GNLSj9IOLFeVnn2n8L2s8pwEdgTlLg9e/S5Eox4i2jkO0JHujtYqe2ac powEHKt9TuT/OGAhuE+2qNylfFfU6KvjEAs5yESnh4dMZy7RI3Cdsz0IpiE8DQShnkpG ZghZw4AotRKgfAlTG3HnFWnDhjmJN1WrV25sr6HQSevI0xfTTsdLZV0iF8k5zy+MEMJ2 XAVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QFMIGRol7sV7/3Q+36hwNIwNbBlX+rl3ShevG/F9H84=; b=EKVP5ZHLbiylelQNoMz0oDsqzGrp44b3w6sJDM4exFjwouEOjsKScSzhBO2hJGgTsy ZLId5jwYOEpzRqkYB0lusxwkYVhwTGhwOegE4qckJHDDIWCCr//2Y0pJiwxu+pfPHoi4 ybtjGZHyxu82ku9fVxuifqOukjorDjDXD9Yt8KHRqadrBmc+viAjbW5hSt8d3qcC5s83 cEnAGoLRfCkbITZ95FbrN5GUHUDggpV08dKmxyB9udi7kGbkGkKX+87CNXa2/wIwpPrU lI0kGfKG6df2TNKArjBBgXs+BoAUe8sO+gt5rrPg0tGZZa3Yi3ZclFvSoPS3dsBhEqHv GWXA== X-Gm-Message-State: AOAM530mWpk3CLr78qw5C6B2BDQdWs9Wl88RdTiPVrR4pDHsMvyAH+VQ 3tsPRiVfc322aWMYCnQqmLfpp+ZEA97dyx4q X-Received: by 2002:aca:f089:: with SMTP id o131mr20450847oih.37.1628610935163; Tue, 10 Aug 2021 08:55:35 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id r5sm3214794otk.71.2021.08.10.08.55.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 08:55:34 -0700 (PDT) Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers To: Greg KH , =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: axboe@kernel.dk, kernelnewbies@kernelnewbies.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, pavel@ucw.cz, pali@kernel.org, hch@lst.de, linux-leds@vger.kernel.org References: <20210809033217.1113444-1-arequipeno@gmail.com> <20210809205633.4300bbea@thinkpad> <81c128a1-c1b8-0f1e-a77b-6704bade26c0@gmail.com> <20210810004331.0f0094a5@thinkpad> <7b5f3509-5bcd-388b-8d3b-4ea95a9483ad@gmail.com> <20210810153840.42419d06@thinkpad> From: Ian Pilcher Message-ID: Date: Tue, 10 Aug 2021 10:55:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/10/21 9:48 AM, Greg KH wrote: > But what about when the device is removed from the system first? Be > careful about that... > > Anyway, sure, try those functions, I really do not know, all I > originally complained about was those exports which did not need to be > exported. Sounds good. I'll work something up. (I'm actually thinking that class_find_device() may be the best way to go, as it grabs a reference to the device.) -- ======================================================================== In Soviet Russia, Google searches you! ========================================================================