Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm8350: fix IPA interconnects
To:     Alex Elder <elder@linaro.org>, bjorn.andersson@linaro.org,
        agross@kernel.org
Cc:     robh+dt@kernel.org, elder@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210804210214.1891755-1-elder@linaro.org>
 <20210804210214.1891755-5-elder@linaro.org>
From:   Georgi Djakov <djakov@kernel.org>
Message-ID: <7a199975-d41a-0716-57d1-7a03af2eb6a4@kernel.org>
Date:   Tue, 10 Aug 2021 19:27:39 +0300
MIME-Version: 1.0
In-Reply-To: <20210804210214.1891755-5-elder@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5.08.21 0:02, Alex Elder wrote:
> There should only be two interconnects defined for IPA on the
> QUalcomm SM8350 SoC.  The names should also match those specified by
> the IPA Device Tree binding.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>

Acked-by: Georgi Djakov <djakov@kernel.org>

> ---
>   arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index a631d58166b1c..01f60a3bd1c14 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -666,12 +666,10 @@ ipa: ipa@1e40000 {
>   			clocks = <&rpmhcc RPMH_IPA_CLK>;
>   			clock-names = "core";
>   
> -			interconnects = <&aggre2_noc MASTER_IPA &gem_noc SLAVE_LLCC>,
> -					<&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1>,
> +			interconnects = <&aggre2_noc MASTER_IPA &mc_virt SLAVE_EBI1>,
>   					<&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_IPA_CFG>;
> -			interconnect-names = "ipa_to_llcc",
> -					     "llcc_to_ebi1",
> -					     "appss_to_ipa";
> +			interconnect-names = "memory",
> +					     "config";
>   
>   			qcom,smem-states = <&ipa_smp2p_out 0>,
>   					   <&ipa_smp2p_out 1>;
>