Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3720940pxt; Tue, 10 Aug 2021 09:47:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuAF06bILchsSixFbKIcJzI471hNOyfyZiHxHlqYMNQfHuoEBXp2XXl8yvQEjvhg1/rXzj X-Received: by 2002:a17:906:3e02:: with SMTP id k2mr28210197eji.479.1628614052339; Tue, 10 Aug 2021 09:47:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628614052; cv=none; d=google.com; s=arc-20160816; b=tZgW5chhOErEFMoJ21fgUHxwngdDGL2FGL97+v5fhLfKVTA6/GT+S9WtSvlCJTYJlG OGy7mfD/ll9HZ4jkcUSfxzieXg3uSwge0EBVR+OCHNb13ylYQufJAi4FXmerRcLm6DaL 1hJKFp54ysKa+gfFXO2M02xEDVPzzUtuyjYFsbAF7YEUuz8Wj+qrv8lqkHaxOrq8tbRz XQzL4gibEmdx3/kLk/DqBLoCxsNj1o43k7Co9J8nkWEtHBS9zApx0WrdWoyUlEl9r6bl onvSWQrP8b9EiV1MBP8HLTQpxH0Rnv7y0QksQN4NMzULckMeqHZUvYLJxz7ry4JKQOk0 5j8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=XsXuHsnr+eKuIQBNM9hBeaZT5+Zuk2ta+rwPuC01OAw=; b=cnYxZE0KP3vQBroF1yMViozjcQroTOKl0bhmcPlkxn72DaB0jIoEYShnMtubIEAdZ6 j/HssmZHXMUEz/oeomnNTBEwrhcSgVITig6msY9qQPk225lDtCjkzgFKyfEbfhwDjdwy EvMUQNpsNojZggDM+U3ULMyThDpDUS8AwdMOXq1LrFJKUYO24aegy8TS4W9S/cHj6pxy KamJi496z4itzHO7Kmc69dPiz8pC2dO2EVioHd3QicGuR9+Y0U85KmRa4yCtON3+ihXK l8r5YIOOgbdQwHhLNbq4cz8caeGI9DJbWrx6mgRwbmIZ2HFtQNzQmOFfGlZozKQNf1MU Oweg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=QitrkNrH; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i20si21096328ejx.267.2021.08.10.09.47.03; Tue, 10 Aug 2021 09:47:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=QitrkNrH; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236598AbhHJQAl (ORCPT + 99 others); Tue, 10 Aug 2021 12:00:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233605AbhHJQAk (ORCPT ); Tue, 10 Aug 2021 12:00:40 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ED04C0613C1 for ; Tue, 10 Aug 2021 09:00:18 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1628611216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XsXuHsnr+eKuIQBNM9hBeaZT5+Zuk2ta+rwPuC01OAw=; b=QitrkNrHsFesKFAGk+c8G+Nn4ysnLt6/EkysLk6zf9VKSdbIGDTEUzSES9RNjogWX45QTb cwtFDHhdGORiOMJe2RJlpPl2w/855hjiDqEvYqigsDFAl/zrDvEm5KECkksk2mI9oq2UCR 9J8/4pmnjsftq7tyOyvsOp5B3n4Vs/wf4hTtLR19u2g88QHz5UanyMTlScu5deeK0GsSOm LDeIbJzOj1oKMPq3HSqlo11bG+PXEUhXP1dNLljs3b1tDwLfGoe25c+1j7VZHiwOFcSCE8 kUq3QeYodjuccM61Rv4Vg7rN+MNR685CXDDa1nr2cbEi8BMG2qg7GOt+POijLw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1628611216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XsXuHsnr+eKuIQBNM9hBeaZT5+Zuk2ta+rwPuC01OAw=; b=k3Nx2Ili89/kmI64z20XoAF1FLI0M2glZzEB2faUSueYxYyw6i+g2YTEvPcd84KGnJLhtV tWwIWNlPbq8dGzCg== To: Jisheng Zhang , John Stultz , Stephen Boyd Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] timer: Use static_branch_likely() for timers_nohz_active In-Reply-To: <20210624163218.39ae3ec6@xhacker.debian> References: <20210624163218.39ae3ec6@xhacker.debian> Date: Tue, 10 Aug 2021 18:00:16 +0200 Message-ID: <87im0dqohb.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jisheng, On Thu, Jun 24 2021 at 16:32, Jisheng Zhang wrote: > The static key timers_nohz_active is likely to be true, so use > static_branch_likely() to reflect this fact. you still lack any justification for your statement that NOHZ active is likely. It might be likely for your system, but is this true in general? Thanks, tglx